Skip to contentSkip to conversation

rocket: Fix mutex locking compile warning

PATCH In review Michael Buesch 2 participants 2 messages Jul 12, 2007 Char and misc drivers

lore
Share & tools
lore

Michael Buesch

author
#0 lore raw

PATCH 1/1 rocket: Fix mutex locking compile warning

This fixes

drivers/char/rocket.c: In function ‘rp_write’:
drivers/char/rocket.c:1705: warning: ignoring return value of ‘mutex_lock_interruptible’, declared with attribute warn_unused_result

Signed-off-by Michael Buesch <[email protected]>
drivers/char/rocket.c +2 -1
Index: bu3sch-wireless-dev/drivers/char/rocket.c
===================================================================
@@ -1702,7 +1702,8 @@ static int rp_write(struct tty_struct *t
 	if (count <= 0 || rocket_paranoia_check(info, "rp_write"))
 		return 0;
 
-	mutex_lock_interruptible(&info->write_mtx);
+	if (mutex_lock_interruptible(&info->write_mtx))
+		return -ERESTARTSYS;
 
 #ifdef ROCKET_DEBUG_WRITE
 	printk(KERN_INFO "rp_write %d chars...", count);
Signature · 1 line
Greetings Michael.
#1 lore raw
Quoted 13 lines · On Thu, 12 Jul 2007 01:56:32 +0200 Michael Buesch <[email protected]> wrote:

This fixes

drivers/char/rocket.c: In function ‘rp_write’:
drivers/char/rocket.c:1705: warning: ignoring return value of ‘mutex_lock_interruptible’, declared with attribute warn_unused_result

Signed-off-by Michael Buesch <[email protected]>

Index: bu3sch-wireless-dev/drivers/char/rocket.c
===================================================================

drivers/char/rocket.c static int rp_write(struct tty_struct *t · line 1709

Quoted 9 lines
drivers/char/rocket.c +2 -1
@@ -1702,7 +1702,8 @@ static int rp_write(struct tty_struct *t
 	if (count <= 0 || rocket_paranoia_check(info, "rp_write"))
 		return 0;
 
-	mutex_lock_interruptible(&info->write_mtx);
+	if (mutex_lock_interruptible(&info->write_mtx))
+		return -ERESTARTSYS;
 
 #ifdef ROCKET_DEBUG_WRITE
 	printk(KERN_INFO "rp_write %d chars...", count);

Thanks, I already have this queued as rocketc-fix-unchecked-mutex_lock_interruptible.patch