Skip to contentSkip to conversation

w1_ds2760: Fix binary file read callback signature

PATCH In review Jean Delvare 2 participants 3 messages Jul 13, 2007 W1 dallas's 1-wire bus

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 w1_ds2760: Fix binary file read callback signature

Commit 91a6902958f052358899f58683d44e36228d85c2 changed the binary sysfs file signatures at the same time the w1_ds2760 driver was added.

---
 drivers/w1/slaves/w1_ds2760.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/w1/slaves/w1_ds2760.c +3 -2
@@ -68,8 +68,9 @@ int w1_ds2760_write(struct device *dev, 
 	return w1_ds2760_io(dev, buf, addr, count, 1);
 }
 
-static ssize_t w1_ds2760_read_bin(struct kobject *kobj, char *buf, loff_t off,
-				  size_t count)
+static ssize_t w1_ds2760_read_bin(struct kobject *kobj,
+				  struct bin_attribute *bin_attr,
+				  char *buf, loff_t off, size_t count)
 {
 	struct device *dev = container_of(kobj, struct device, kobj);
 	return w1_ds2760_read(dev, buf, off, count);
Signature · 1 line
Jean Delvare
#2 lore raw

Hi Evgeniy,

Quoted 8 lines · Evgeniy Polyakov
Quoted 4 lines · Jean Delvare

Commit 91a6902958f052358899f58683d44e36228d85c2 changed the binary sysfs file signatures at the same time the w1_ds2760 driver was added.

I have no problem with this patch. Should I forward it to Andrew or you will pick this up?

Please forward it to Andrew.

Thanks,

Signature · 1 line
Jean Delvare