Skip to contentSkip to conversation

SELinux changes for 2.6.23 (updated)

GIT Paul Moore 3 participants 4 messages Jul 13, 2007 – Jul 14, 2007

lore
Share & tools
lore

Paul Moore

author
#0 lore raw

-----Original Message-----
From: James Morris <[email protected]>
Date: Thursday, Jul 12, 2007 10:50 pm
Subject: Re: [GIT] SELinux changes for 2.6.23 (updated)
To: Michal Piotrowski <[email protected]>
CC: Linus Torvalds <[email protected]>, [email protected], Stephen Smalley <[email protected]>, Paul Moore <[email protected]>

Quoted 7 lines · Michal Piotrowski
Quoted 2 lines

My system is too secure, I can not login :)

Do you have CONFIG_NETLABEL=y ?

If so, please try disabling it.

Disabling NetLabel should solve the problem. The recommended solution to this problem, as discussed on the SELinux list and mentioned in the patch description, is to upgrade your SELinux policy to the latest Reference Policy sources. For those with custom SELinux policy, the patch description explains the changes to the SELinux policy required.

If needed I can post more instructions later, let me know, but right now I'm tapping this out on my phone while at the airport.

. paul moore
. linux security @ hp

#1 lore raw

The art of breaking userspace (was Re: [GIT] SELinux changes for 2.6.23 (updated))

Paul Moore pisze:
[..]

Quoted 8 lines · Michal Piotrowski
Quoted 5 lines

My system is too secure, I can not login :)

Do you have CONFIG_NETLABEL=y ?

If so, please try disabling it.

Disabling NetLabel should solve the problem.

Disabling NetLabel solves the problem.

Quoted 1 line

The recommended solution to this problem, as discussed on the SELinux list and mentioned in the patch description, is to upgrade your SELinux policy to the latest Reference Policy sources. For those with custom SELinux policy, the patch description explains the changes to the SELinux policy required.

I'm sorry to say this, but this kind of patches should not be accepted.

Patch

commit 9faf65fb6ee2b4e08325ba2d69e5ccf0c46453d0

Author: Paul Moore <[email protected]>
Date:   Fri Jun 29 11:48:16 2007 -0400

SELinux: use SECINITSID_NETMSG instead of SECINITSID_UNLABELED for NetLabel

These changes will make NetLabel behave like labeled IPsec where there is an access check for both labeled and unlabeled packets as well as providing the ability to restrict domains to receiving only labeled packets when NetLabel is in use. The changes to the policy are straight forward with the following necessary to receive labeled traffic (with SECINITSID_NETMSG defined as "netlabel_peer_t"):

allow mydom_t netlabel_peer_t:{ tcp_socket udp_socket rawip_socket } recvfrom;

The policy for unlabeled traffic would be:

allow mydom_t unlabeled_t:{ tcp_socket udp_socket rawip_socket } recvfrom;

These policy changes, as well as more general NetLabel support, are included in the SELinux Reference Policy SVN tree, r2352 or later. Users who enable NetLabel support in the kernel are strongly encouraged to upgrade their policy to avoid network problems.

breaks systems with recent selinux policy.

(rpm -qa selinux-policy-*
selinux-policy-devel-2.6.4-25.fc7
selinux-policy-targeted-2.6.4-25.fc7)

I will add this as a regression unless Linus says "Fsck it! We don't care about compatibility"

Quoted 8 lines

If needed I can post more instructions later, let me know, but right now I'm tapping this out on my phone while at the airport.

. paul moore
. linux security @ hp

Regards,
Michal

Signature · 2 lines
LOG
http://www.stardust.webpages.pl/log/
#2 lore raw

Re: The art of breaking userspace (was Re: [GIT] SELinux changes for 2.6.23 (updated))

Quoted 47 lines · Michal Piotrowski

Paul Moore pisze:
[..]

Quoted 8 lines · Michal Piotrowski
Quoted 5 lines

My system is too secure, I can not login :)

Do you have CONFIG_NETLABEL=y ?

If so, please try disabling it.

Disabling NetLabel should solve the problem.

Disabling NetLabel solves the problem.

Quoted 1 line

The recommended solution to this problem, as discussed on the SELinux list and mentioned in the patch description, is to upgrade your SELinux policy to the latest Reference Policy sources. For those with custom SELinux policy, the patch description explains the changes to the SELinux policy required.

I'm sorry to say this, but this kind of patches should not be accepted.

Patch

commit 9faf65fb6ee2b4e08325ba2d69e5ccf0c46453d0

Author: Paul Moore <[email protected]>
Date:   Fri Jun 29 11:48:16 2007 -0400

SELinux: use SECINITSID_NETMSG instead of SECINITSID_UNLABELED for NetLabel

These changes will make NetLabel behave like labeled IPsec where there is an access check for both labeled and unlabeled packets as well as providing the ability to restrict domains to receiving only labeled packets when NetLabel is in use. The changes to the policy are straight forward with the following necessary to receive labeled traffic (with SECINITSID_NETMSG defined as "netlabel_peer_t"):

allow mydom_t netlabel_peer_t:{ tcp_socket udp_socket rawip_socket } recvfrom;

The policy for unlabeled traffic would be:

allow mydom_t unlabeled_t:{ tcp_socket udp_socket rawip_socket } recvfrom;

These policy changes, as well as more general NetLabel support, are included in the SELinux Reference Policy SVN tree, r2352 or later. Users who enable NetLabel support in the kernel are strongly encouraged to upgrade their policy to avoid network problems.

Quoted 7 lines

breaks systems with recent selinux policy.

(rpm -qa selinux-policy-*
selinux-policy-devel-2.6.4-25.fc7
selinux-policy-targeted-2.6.4-25.fc7)

I will add this as a regression unless Linus says "Fsck it! We don't care about compatibility"

Agreed, it needs to be fixed in the netlabel code.

Signature · 2 lines
Stephen Smalley
National Security Agency
author
#3 lore raw

Re: The art of breaking userspace (was Re: [GIT] SELinux changes for 2.6.23 (updated))

Quoted 1 line · Stephen Smalley

Agreed, it needs to be fixed in the netlabel code.

For anyone interested, and for the sake of completeness, an updated patch[set] has been posted to the SELinux mailing list for review. The new patchset is designed to fix the problem that Michal reported.

Signature · 2 lines
paul moore
linux security @ hp