Skip to contentSkip to conversation

Merge the Sonics Silicon Backplane subsystem

PATCH In review Michael Buesch 3 participants 3 messages Jul 14, 2007 2 messages not in the archive

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Merge the Sonics Silicon Backplane subsystem

This merges the SSB subsystem. SSB is a backplane bus subsystem needed for various Broadcom devices.

The comments from submit attempt #1 are addressed in this patch.

drivers/Makefile +1 -0
index 503d825..c01b7f1 100644
@@ -82,3 +82,4 @@ obj-$(CONFIG_GENERIC_TIME)	+= clocksourc
 obj-$(CONFIG_DMA_ENGINE)	+= dma/
 obj-$(CONFIG_HID)		+= hid/
 obj-$(CONFIG_PPC_PS3)		+= ps3/
+obj-$(CONFIG_SSB)		+= ssb/
drivers/Kconfig +2 -0
index 7916f4b..dc8df05 100644
@@ -56,6 +56,8 @@ source "drivers/power/Kconfig"
 
 source "drivers/hwmon/Kconfig"
 
+source "drivers/ssb/Kconfig"
+
 source "drivers/mfd/Kconfig"
 
 source "drivers/media/Kconfig"
drivers/ssb/Makefile new file +11 -0
new file mode 100644
index 0000000..9a2b379
@@ -0,0 +1,11 @@
+ssb-builtin-drivers-y					+= driver_chipcommon.o
+ssb-builtin-drivers-$(CONFIG_SSB_DRIVER_MIPS)		+= driver_mipscore.o
+ssb-builtin-drivers-$(CONFIG_SSB_DRIVER_PCICORE)	+= driver_pcicore.o
+
+ssb-hostsupport-$(CONFIG_SSB_PCIHOST)			+= pci.o pcihost_wrapper.o
+ssb-hostsupport-$(CONFIG_SSB_PCMCIAHOST)		+= pcmcia.o
+
+obj-$(CONFIG_SSB) += ssb.o
+
+ssb-objs	:= main.o scan.o \
+		   $(ssb-hostsupport-y) $(ssb-builtin-drivers-y)
drivers/ssb/Kconfig new file +93 -0

93 lines not on this page · raw message

drivers/ssb/driver_chipcommon.c new file +394 -0

394 lines not on this page · raw message

drivers/ssb/driver_mipscore.c new file +258 -0

258 lines not on this page · raw message

drivers/ssb/driver_pcicore.c new file +557 -0

557 lines not on this page · raw message

drivers/ssb/main.c new file +1061 -0

1,061 lines not on this page · raw message

drivers/ssb/pci.c new file +688 -0

614 lines not on this page · raw message

drivers/ssb/pcihost_wrapper.c new file +104 -0

104 lines not on this page · raw message

drivers/ssb/pcmcia.c new file +266 -0

266 lines not on this page · raw message

drivers/ssb/scan.c new file +415 -0

415 lines not on this page · raw message

drivers/ssb/ssb_private.h new file +122 -0

122 lines not on this page · raw message

include/linux/ssb/ssb_driver_chipcommon.h new file +387 -0

387 lines not on this page · raw message

include/linux/ssb/ssb_driver_extif.h new file +163 -0

163 lines not on this page · raw message

include/linux/ssb/ssb_driver_mips.h new file +47 -0

47 lines not on this page · raw message

include/linux/ssb/ssb_driver_pci.h new file +108 -0

108 lines not on this page · raw message

include/linux/ssb/ssb.h new file +420 -0

420 lines not on this page · raw message

include/linux/ssb/ssb_regs.h new file +294 -0

294 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
Greetings Michael.

Part of the diff is not shown here. View the raw message.

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 4 lines · Michael Buesch
drivers/ssb/Makefile new file +1 -0
@@ -0,0 +1,11 @@
+ssb-builtin-drivers-y					+= driver_chipcommon.o

drivers/ssb/Makefile line 11

Quoted 10 lines
drivers/ssb/Makefile new file +10 -0
+ssb-builtin-drivers-$(CONFIG_SSB_DRIVER_MIPS)		+= driver_mipscore.o
+ssb-builtin-drivers-$(CONFIG_SSB_DRIVER_PCICORE)	+= driver_pcicore.o
+
+ssb-hostsupport-$(CONFIG_SSB_PCIHOST)			+= pci.o pcihost_wrapper.o
+ssb-hostsupport-$(CONFIG_SSB_PCMCIAHOST)		+= pcmcia.o
+
+obj-$(CONFIG_SSB) += ssb.o
+
+ssb-objs	:= main.o scan.o \
+		   $(ssb-hostsupport-y) $(ssb-builtin-drivers-y)

Whoa, this makefile is more than ugly :)

Please try something like:

# core
ssb-y					+= main.o scan.o
# host support
ssb-$(CONFIG_SSB_PCIHOST)		+= pci.o pcihost_wrapper.o
ssb-$(CONFIG_SSB_PCMCIAHOST)		+= pcmcia.o
# drivers
ssb-y					+= driver_chipcommon.o
ssb-$(CONFIG_SSB_DRIVER_MIPS)		+= driver_mipscore.o
ssb-$(CONFIG_SSB_DRIVER_PCICORE)	+= driver_pcicore.o

obj-$(CONFIG_SSB) += ssb.o

instead

drivers/ssb/Makefile

Quoted 1 line
drivers/ssb/Makefile new file +1 -0
+	default y

please don't add defauly y statements for random drivers.

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw
Quoted 32 lines · On Saturday 14 July 2007 19:26:05 Christoph Hellwig wrote:
Quoted 4 lines · Michael Buesch
drivers/ssb/Makefile new file +1 -0
@@ -0,0 +1,11 @@
+ssb-builtin-drivers-y					+= driver_chipcommon.o

drivers/ssb/Makefile line 11

Quoted 10 lines
drivers/ssb/Makefile new file +10 -0
+ssb-builtin-drivers-$(CONFIG_SSB_DRIVER_MIPS)		+= driver_mipscore.o
+ssb-builtin-drivers-$(CONFIG_SSB_DRIVER_PCICORE)	+= driver_pcicore.o
+
+ssb-hostsupport-$(CONFIG_SSB_PCIHOST)			+= pci.o pcihost_wrapper.o
+ssb-hostsupport-$(CONFIG_SSB_PCMCIAHOST)		+= pcmcia.o
+
+obj-$(CONFIG_SSB) += ssb.o
+
+ssb-objs	:= main.o scan.o \
+		   $(ssb-hostsupport-y) $(ssb-builtin-drivers-y)

Whoa, this makefile is more than ugly :)

Please try something like:

# core
ssb-y					+= main.o scan.o
# host support
ssb-$(CONFIG_SSB_PCIHOST)		+= pci.o pcihost_wrapper.o
ssb-$(CONFIG_SSB_PCMCIAHOST)		+= pcmcia.o
# drivers
ssb-y					+= driver_chipcommon.o
ssb-$(CONFIG_SSB_DRIVER_MIPS)		+= driver_mipscore.o
ssb-$(CONFIG_SSB_DRIVER_PCICORE)	+= driver_pcicore.o
Quoted 9 lines

obj-$(CONFIG_SSB) += ssb.o

instead

drivers/ssb/Makefile

Quoted 1 line
drivers/ssb/Makefile new file +1 -0
+	default y

please don't add defauly y statements for random drivers.

Thanks for your comments. I fixed that and will submit it with the next round.

Signature · 1 line
Greetings Michael.