Skip to contentSkip to conversation

sysctl.c: add text telling people to use CTL_UNNUMBERED

DISCUSSION Randy Dunlap 2 participants 2 messages Jul 16, 2007 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 39 lines · On Mon, 16 Jul 2007 18:02:43 GMT Linux Kernel Mailing List wrote:
Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=2be7fe075af8f8ba9c8b8ab0feec4ba4fff04979
Commit:     2be7fe075af8f8ba9c8b8ab0feec4ba4fff04979
Parent:     97d8f83cb734525f96992fd61e4f7323ab3d549c
Author:     Andrew Morton <[email protected]>
AuthorDate: Sun Jul 15 23:41:21 2007 -0700
Committer:  Linus Torvalds <[email protected]>
CommitDate: Mon Jul 16 09:05:49 2007 -0700

sysctl.c: add text telling people to use CTL_UNNUMBERED

Hopefully this will help people to understand the new regime.

---
 kernel/sysctl.c |   21 ++++++++++++++++++++-
 1 files changed, 20 insertions(+), 1 deletions(-)
kernel/sysctl.c +4 -1
index 2cce228..7dca326 100644
@@ -203,7 +203,10 @@ static ctl_table root_table[] = {
 		.mode		= 0555,
 		.child		= dev_table,
 	},
-
+/*
+ * NOTE: do not add new entries to this table unless you have read
+ * Documentation/sysctl/ctl_unnumbered.txt
+ */
 	{ .ctl_name = 0 }
 };
 
@@ -992,6 +995,14 @@ static ctl_table vm_table[] = {
 		.extra1		= &zero,
 	},
 #endif

kernel/sysctl.c static ctl_table vm_table[] = { · line 1007

Quoted 10 lines
kernel/sysctl.c +8 -0
+/*
+ * NOTE: do not add new entries to this table unless you have read
+ * Documentation/sysctl/ctl_unnumbered.txt
+ */
+/*
+ * NOTE: do not add new entries to this table unless you have read
+ * Documentation/sysctl/ctl_unnumbered.txt
+ */
 	{ .ctl_name = 0 }
 };

Are these comments above & below doubled up for Emphasis??

Quoted 4 lines
kernel/sysctl.c +0 -0
@@ -1132,6 +1143,14 @@ static ctl_table fs_table[] = {
 		.child		= binfmt_misc_table,
 	},
 #endif

kernel/sysctl.c static ctl_table fs_table[] = { · line 1155

Quoted 10 lines
kernel/sysctl.c +8 -0
+/*
+ * NOTE: do not add new entries to this table unless you have read
+ * Documentation/sysctl/ctl_unnumbered.txt
+ */
+/*
+ * NOTE: do not add new entries to this table unless you have read
+ * Documentation/sysctl/ctl_unnumbered.txt
+ */
 	{ .ctl_name = 0 }
 };

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

#2 lore raw
Quoted 4 lines · On Mon, 16 Jul 2007 11:23:05 -0700 Randy Dunlap <[email protected]> wrote:
Quoted 4 lines

+/*
+ * NOTE: do not add new entries to this table unless you have read
+ * Documentation/sysctl/ctl_unnumbered.txt
+ */

Quoted 8 lines

Review

Quoted 6 lines
(quoted diff) +4 -0
+/*
+ * NOTE: do not add new entries to this table unless you have read
+ * Documentation/sysctl/ctl_unnumbered.txt
+ */
 	{ .ctl_name = 0 }
 };

Are these comments above & below doubled up for Emphasis??

hm, that could have been some late-night reject-fixing.

sysctl.c is (hopefully "was") the second worst source of rejects in the tree.

PITA #1 is Documentation/feature-removal-schedule.txt, but that is fortunately amenable to the insert-it-at-a-random-position solution.