Skip to contentSkip to conversation

um_kmalloc() remnants

PATCH In review Al Viro 3 participants 4 messages Jul 17, 2007 User-mode Linux (UML)

lore
Share & tools
lore

Al Viro

author
#0 lore raw

PATCH 1/1 um_kmalloc() remnants

Signed-off-by Al Viro <[email protected]>
---
 arch/um/drivers/pcap_user.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/um/drivers/pcap_user.c +1 -1
index 483aa15..1316456 100644
@@ -53,7 +53,7 @@ static int pcap_open(void *data)
 			return -EIO;
 		}
 
-		pri->compiled = um_kmalloc(sizeof(struct bpf_program));
+		pri->compiled = kmalloc(sizeof(struct bpf_program), UM_GFP_KERNEL);
 		if(pri->compiled == NULL){
 			printk(UM_KERN_ERR "pcap_open : kmalloc failed\n");
 			return -ENOMEM;
Signature · 1 line
1.5.3.GIT
#1 lore raw

arch/um/drivers/pcap_user.c static int pcap_open(void *data) · line 56

Quoted 2 lines · Al Viro
arch/um/drivers/pcap_user.c +1 -1
-               pri->compiled = um_kmalloc(sizeof(struct bpf_program));
+               pri->compiled = kmalloc(sizeof(struct bpf_program), UM_GFP_KERNEL);

GFP_KERNEL?

#2 lore raw
Quoted 2 lines · Al Viro
Quoted 2 lines
arch/um/drivers/pcap_user.c +1 -1
-               pri->compiled = um_kmalloc(sizeof(struct bpf_program));
+               pri->compiled = kmalloc(sizeof(struct bpf_program), UM_GFP_KERNEL);
Quoted 1 line · Pekka Enberg

GFP_KERNEL?

Uhm, missed this: http://lkml.org/lkml/2007/6/14/374. Sorry for the noise.