kernel/sched.c: remove 2 unused exports
PATCH 1/1 kernel/sched.c: remove 2 unused exports
This patch removes the following unused exports:
- EXPORT_SYMBOL(cond_resched_softirq);
- EXPORT_SYMBOL_GPL(__wake_up_sync);
---
kernel/sched.c | 2 -- 1 file changed, 2 deletions(-)
kernel/sched.c renamed from kernel/sched.c.old +0 -2
@@ -3517,7 +3517,6 @@__wake_up_common (q, mode, nr_exclusive, sync,NULL );spin_unlock_irqrestore (&q->lock, flags); } -EXPORT_SYMBOL_GPL (__wake_up_sync);/* For internal use only */ void fastcall complete(struct completion *x) {
@@ -4453,7 +4452,6 @@ }return 0 ; } -EXPORT_SYMBOL (cond_resched_softirq);/** * yield - yield the current processor to other threads.
Quoted 3 lines · Adrian Bunk
This patch removes the following unused exports:
-EXPORT_SYMBOL(cond_resched_softirq);
-EXPORT_SYMBOL_GPL(__wake_up_sync);
these are there for API completeness - their counterparts are exported.
Ingo
Quoted 8 lines · Ingo Molnar
Quoted 3 lines · Adrian Bunk
This patch removes the following unused exports:
-EXPORT_SYMBOL(cond_resched_softirq);
-EXPORT_SYMBOL_GPL(__wake_up_sync);these are there for API completeness - their counterparts are exported.
Why is something with a comment "For internal use only" part of the API?
Quoted 1 line
Ingo
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedQuoted 4 lines · Adrian Bunk
Quoted 3 lines · Ingo Molnar
* Adrian Bunk <[email protected]> wrote:
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
This patch removes the following unused exports:
-EXPORT_SYMBOL(cond_resched_softirq);
-EXPORT_SYMBOL_GPL(__wake_up_sync);these are there for API completeness - their counterparts are exported.
Why is something with a comment "For internal use only" part of the API?
yeah, you are right about __wake_up_sync. We'll likely remove sync wakeups anyway, and the export is GPL, so it's not a big issue.
The point remains for cond_resched_softirq() though - it's a symmetric export to cond_resched()'s export. (I think you should smarten your scripts about such 'API family' exports, to avoid false positives.)
Ingo