cell: driver for DDR2 memory on AXON
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 9 lines · Christoph Hellwig
Quoted 5 lines
None of these seems to make any difference whatsoever, except for BLKBSZGET returning non-zero on a ramdisk or dcssblk device. I think we'd be best off removing
bd_block_sizefrom the kernel altogether, and I'll remove it from the axon-ram driver now.Yes, please. I even have patches that only pass struct gendisk to block device ->open, so this couldn't work anymore anyway. And yes, the ramdisk driver is doing some really odd things.
Any suggestion on what BLKBSZGET should return?
1) blocksize = 0 (same as it does already for most devices)
2) return -EINVAL
3) same as BLKSSZGET
4) return -ENOTTY
It probably doesn't matter much as any user of BLKBSZGET is already broken, but it would be good to do the right thing since it is a documented interface.
Arnd <><
Quoted 3 lines
Any suggestion on what BLKBSZGET should return?
1) blocksize = 0 (same as it does already for most devices)
This is what tools like df expect