Fix a small memory leak in the cciss driver
PATCH 1/1 Fix a small memory leak in the cciss driver
Hello,
There's a memory leak in the cciss driver.
in alloc_cciss_hba() we may leak sizeof(ctlr_info_t) bytes if a call to alloc_disk(1 << NWD_SHIFT) fails.
This patch should fix the issue.
Spotted by the Coverity checker.
Compile tested only.
Signed-off-by Jesper Juhl <[email protected]>
---
drivers/block/cciss.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)
drivers/block/cciss.c +4 -1
@@ -3227,12 +3227,15 @@ static int alloc_cciss_hba(void)for (i =0 ; i <MAX_CTLR ; i++) {if (!hba[i]) {ctlr_info_t *p; + p =kzalloc (sizeof (ctlr_info_t),GFP_KERNEL );if (!p) goto Enomem; p->gendisk[0 ] =alloc_disk (1 <<NWD_SHIFT ); -if (!p->gendisk[0 ]) +if (!p->gendisk[0 ]) { +kfree (p); goto Enomem; + } hba[i] = p;return i; }