Skip to contentSkip to conversation

bsg: fix bsg_unregister_queue

PATCH New FUJITA Tomonori 1 participant 1 message Jul 21, 2007

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bsg: fix bsg_unregister_queue

scsi_sysfs_add_sdev ignores the bsg_register_queue failure, so bsg_unregister_queue must check whether the queue has a bsg device.

---
 block/bsg.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
block/bsg.c +2 -1
index 4eebcd5..1ba9bc6 100644
@@ -932,7 +932,8 @@ void bsg_unregister_queue(struct request
 {
 	struct bsg_class_device *bcd = &q->bsg_dev;
 
-	WARN_ON(!bcd->class_dev);
+	if (!bcd->class_dev)
+		return;
 
 	mutex_lock(&bsg_mutex);
 	sysfs_remove_link(&q->kobj, "bsg");
Signature · 1 line
1.4.3.2