pcwd_init_module(): WARNING: at lib/kref.c:33 kref_get()
enabling CONFIG_PCWATCHDOG=y crashes bzImage bootup, see below. Tested on latest -git.
Ingo
------------------->
Calling initcall 0xc1e81f8c: pcwd_init_module+0x0/0x14()
WARNING: at lib/kref.c:33 kref_get() [<c0105f6e>] show_trace_log_lvl+0x19/0x2e [<c0106067>] show_trace+0x12/0x14 [<c010607d>] dump_stack+0x14/0x16 [<c051aa54>] kref_get+0x37/0x40 [<c0519dfe>] kobject_get+0x12/0x17 [<c06fd12a>] get_bus+0x11/0x21 [<c06fd729>] bus_add_driver+0x18/0x16b [<c06fe45a>] driver_register+0x66/0x6b [<c0702575>] isa_register_driver+0x27/0x126 [<c1e81f9e>] pcwd_init_module+0x12/0x14 [<c1e50838>] kernel_init+0x15a/0x2df [<c0105d87>] kernel_thread_helper+0x7/0x10 ======================= WARNING: at lib/kref.c:33 kref_get() [<c0105f6e>] show_trace_log_lvl+0x19/0x2e [<c0106067>] show_trace+0x12/0x14 [<c010607d>] dump_stack+0x14/0x16 [<c051aa54>] kref_get+0x37/0x40 [<c0519dfe>] kobject_get+0x12/0x17 [<c051a429>] kobject_init+0x32/0x43 [<c051a4c3>] kobject_register+0x15/0x31 [<c06fd76d>] bus_add_driver+0x5c/0x16b [<c06fe45a>] driver_register+0x66/0x6b [<c0702575>] isa_register_driver+0x27/0x126 [<c1e81f9e>] pcwd_init_module+0x12/0x14 [<c1e50838>] kernel_init+0x15a/0x2df [<c0105d87>] kernel_thread_helper+0x7/0x10 ======================= BUG: spinlock bad magic on CPU#0, swapper/1 lock: c1b6a888, .magic: 00000000, .owner: <none>/-1, .owner_cpu: 0 [<c0105f6e>] show_trace_log_lvl+0x19/0x2e [<c0106067>] show_trace+0x12/0x14 [<c010607d>] dump_stack+0x14/0x16 [<c052b0be>] spin_bug+0xa1/0xa9 [<c052b289>] _raw_spin_lock+0x1e/0x104 [<c1385f7e>] _spin_lock+0x54/0x62 [<c051a026>] kobject_shadow_add+0x84/0x171 [<c051a11d>] kobject_add+0xa/0xc [<c051a4ca>] kobject_register+0x1c/0x31 [<c06fd76d>] bus_add_driver+0x5c/0x16b [<c06fe45a>] driver_register+0x66/0x6b [<c0702575>] isa_register_driver+0x27/0x126 [<c1e81f9e>] pcwd_init_module+0x12/0x14 [<c1e50838>] kernel_init+0x15a/0x2df [<c0105d87>] kernel_thread_helper+0x7/0x10 =======================
Quoted 8 lines · Ingo Molnar
enabling
CONFIG_PCWATCHDOG=ycrashes bzImage bootup, see below. Tested on latest -git.Ingo
------------------->
Calling initcall0xc1e81f8c: pcwd_init_module+0x0/0x14()
Quoted 14 lines
WARNING: at lib/kref.c:33 kref_get() [<c0105f6e>] show_trace_log_lvl+0x19/0x2e [<c0106067>] show_trace+0x12/0x14 [<c010607d>] dump_stack+0x14/0x16 [<c051aa54>] kref_get+0x37/0x40 [<c0519dfe>] kobject_get+0x12/0x17 [<c06fd12a>] get_bus+0x11/0x21 [<c06fd729>] bus_add_driver+0x18/0x16b [<c06fe45a>] driver_register+0x66/0x6b [<c0702575>] isa_register_driver+0x27/0x126 [<c1e81f9e>] pcwd_init_module+0x12/0x14 [<c1e50838>] kernel_init+0x15a/0x2df [<c0105d87>] kernel_thread_helper+0x7/0x10 =======================
Trying to kref_get() isa_driver.device_driver.bus->subsys.kobj.kref but it hasn't even been kref_init()'ed yet/already.
Quoted 7 lines
WARNING: at lib/kref.c:33 kref_get() [<c0105f6e>] show_trace_log_lvl+0x19/0x2e [<c0106067>] show_trace+0x12/0x14 [<c010607d>] dump_stack+0x14/0x16 [<c051aa54>] kref_get+0x37/0x40 [<c0519dfe>] kobject_get+0x12/0x17 [<c051a429>] kobject_init+0x32/0x43
Quoted 8 lines
[<c051a4c3>] kobject_register+0x15/0x31 [<c06fd76d>] bus_add_driver+0x5c/0x16b [<c06fe45a>] driver_register+0x66/0x6b [<c0702575>] isa_register_driver+0x27/0x126 [<c1e81f9e>] pcwd_init_module+0x12/0x14 [<c1e50838>] kernel_init+0x15a/0x2df [<c0105d87>] kernel_thread_helper+0x7/0x10 =======================
Trying to kref_get() isa_driver.device_driver.kobj.kset->kobj.kref but it hasn't even been kref_init()'ed yet/already.
Quoted 10 lines
BUG: spinlock bad magic on CPU#0, swapper/1 lock: c1b6a888, .magic: 00000000, .owner: <none>/-1, .owner_cpu: 0 [<c0105f6e>] show_trace_log_lvl+0x19/0x2e [<c0106067>] show_trace+0x12/0x14 [<c010607d>] dump_stack+0x14/0x16 [<c052b0be>] spin_bug+0xa1/0xa9 [<c052b289>] _raw_spin_lock+0x1e/0x104 [<c1385f7e>] _spin_lock+0x54/0x62 [<c051a026>] kobject_shadow_add+0x84/0x171 [<c051a11d>] kobject_add+0xa/0xc
Quoted 8 lines
[<c051a4ca>] kobject_register+0x1c/0x31 [<c06fd76d>] bus_add_driver+0x5c/0x16b [<c06fe45a>] driver_register+0x66/0x6b [<c0702575>] isa_register_driver+0x27/0x126 [<c1e81f9e>] pcwd_init_module+0x12/0x14 [<c1e50838>] kernel_init+0x15a/0x2df [<c0105d87>] kernel_thread_helper+0x7/0x10 =======================
Trying to spin_lock() isa_driver.device_driver.kobj.kset->list_lock but it hasn't even been spin_lock_init()'ed already.
Greg/Cornelia, any idea when/why would such errors normally occur?
Thanks,
Satyam
Hi all,
Quoted 4 lines · Ingo Molnar
Quoted 3 lines
enabling
CONFIG_PCWATCHDOG=ycrashes bzImage bootup, see below. Tested on latest -git.
I'll have a look at it when I'm back home and I can test it (within a week).
Greetings,
Wim.
Quoted 65 lines · Satyam Sharma
Quoted 8 lines · Ingo Molnar
enabling
CONFIG_PCWATCHDOG=ycrashes bzImage bootup, see below. Tested on latest -git.Ingo
------------------->
Calling initcall0xc1e81f8c: pcwd_init_module+0x0/0x14()Quoted 14 lines
WARNING: at lib/kref.c:33 kref_get() [<c0105f6e>] show_trace_log_lvl+0x19/0x2e [<c0106067>] show_trace+0x12/0x14 [<c010607d>] dump_stack+0x14/0x16 [<c051aa54>] kref_get+0x37/0x40 [<c0519dfe>] kobject_get+0x12/0x17 [<c06fd12a>] get_bus+0x11/0x21 [<c06fd729>] bus_add_driver+0x18/0x16b [<c06fe45a>] driver_register+0x66/0x6b [<c0702575>] isa_register_driver+0x27/0x126 [<c1e81f9e>] pcwd_init_module+0x12/0x14 [<c1e50838>] kernel_init+0x15a/0x2df [<c0105d87>] kernel_thread_helper+0x7/0x10 =======================Trying to
kref_get()isa_driver.device_driver.bus->subsys.kobj.krefbut it hasn't even been kref_init()'ed yet/already.Quoted 7 lines
WARNING: at lib/kref.c:33 kref_get() [<c0105f6e>] show_trace_log_lvl+0x19/0x2e [<c0106067>] show_trace+0x12/0x14 [<c010607d>] dump_stack+0x14/0x16 [<c051aa54>] kref_get+0x37/0x40 [<c0519dfe>] kobject_get+0x12/0x17 [<c051a429>] kobject_init+0x32/0x43Quoted 8 lines
[<c051a4c3>] kobject_register+0x15/0x31 [<c06fd76d>] bus_add_driver+0x5c/0x16b [<c06fe45a>] driver_register+0x66/0x6b [<c0702575>] isa_register_driver+0x27/0x126 [<c1e81f9e>] pcwd_init_module+0x12/0x14 [<c1e50838>] kernel_init+0x15a/0x2df [<c0105d87>] kernel_thread_helper+0x7/0x10 =======================Trying to
kref_get()isa_driver.device_driver.kobj.kset->kobj.krefbut it hasn't even been kref_init()'ed yet/already.Quoted 10 lines
BUG: spinlock bad magic on CPU#0, swapper/1 lock: c1b6a888, .magic: 00000000, .owner: <none>/-1, .owner_cpu: 0 [<c0105f6e>] show_trace_log_lvl+0x19/0x2e [<c0106067>] show_trace+0x12/0x14 [<c010607d>] dump_stack+0x14/0x16 [<c052b0be>] spin_bug+0xa1/0xa9 [<c052b289>] _raw_spin_lock+0x1e/0x104 [<c1385f7e>] _spin_lock+0x54/0x62 [<c051a026>] kobject_shadow_add+0x84/0x171 [<c051a11d>] kobject_add+0xa/0xcQuoted 8 lines
[<c051a4ca>] kobject_register+0x1c/0x31 [<c06fd76d>] bus_add_driver+0x5c/0x16b [<c06fe45a>] driver_register+0x66/0x6b [<c0702575>] isa_register_driver+0x27/0x126 [<c1e81f9e>] pcwd_init_module+0x12/0x14 [<c1e50838>] kernel_init+0x15a/0x2df [<c0105d87>] kernel_thread_helper+0x7/0x10 =======================
Quoted 4 lines
Trying to
spin_lock()isa_driver.device_driver.kobj.kset->list_lockbut it hasn't even been spin_lock_init()'ed already.Greg/Cornelia, any idea when/why would such errors normally occur?
Might be some ordering problem (bus not registered yet). Is the isa bus already up? Changing link order or initcall levels might help.
Hi All,
Quoted 7 lines
Quoted 4 lines · Satyam Sharma
Quoted 3 lines · Ingo Molnar
enabling
CONFIG_PCWATCHDOG=ycrashes bzImage bootup, see below. Tested on latest -git.
...
Quoted 3 lines
Might be some ordering problem (bus not registered yet). Is the isa bus already up? Changing link order or initcall levels might help.
See below fix. Please test it.
Thanks in advance,
Wim.
[WATCHDOG] Fix pcwd_init_module crash
Fix for the problem detected by Ingo Molnar:
enabling CONFIG_PCWATCHDOG=y crashes bzImage bootup.
The reason for this can be found in drivers/makefile We first do:
obj-y += char/
and later we do:
obj-y += base/ block/ misc/ mfd/ net/ media/
So if we put a platform or isa or usb bus driver in char/watchdog (which is called from the Makefile in drivers/char/Makefile) then we didn't have the different device drivers initialized yet (they are in drivers/base and drivers/usb and ...)
This fix makes sure that we compile the watchdog drivers after drivers/base, drivers/misc, drivers/pci and drivers/usb. We also do the compile after hwmon because in the future the watchdog temperature support will use the hwmon system.
drivers/Makefile +1 -0
@@ -66,6 +66,7 @@ obj-y += i2c/ obj-$(CONFIG_W1) += w1/ obj-$(CONFIG_POWER_SUPPLY) += power/ obj-$(CONFIG_HWMON) += hwmon/ +obj-$(CONFIG_WATCHDOG) += char/watchdog/ obj-$(CONFIG_PHONE) += telephony/ obj-$(CONFIG_MD) += md/ obj-$(CONFIG_BT) += bluetooth/
drivers/char/Makefile +0 -1
@@ -97,7 +97,6 @@ obj-$(CONFIG_GPIO_VR41XX) += vr41xx_giu.o obj-$(CONFIG_GPIO_TB0219) += tb0219.o obj-$(CONFIG_TELCLOCK) += tlclk.o -obj-$(CONFIG_WATCHDOG) += watchdog/ obj-$(CONFIG_MWAVE) += mwave/ obj-$(CONFIG_AGP) += agp/ obj-$(CONFIG_DRM) += drm/
Ingo Molnar
Acked-byQuoted 1 line · Wim Van Sebroeck
See below fix. Please test it.
thanks, this fixes the crash!
Michal, please mark this .23 regression entry as resolved:
Subject : pcwd_init_module(): WARNING: at lib/kref.c:33 kref_get()
References : http://lkml.org/lkml/2007/7/22/94
Last known good : ?
Submitter : Ingo Molnar <[email protected]> Caused-By : ? Handled-By : Wim Van Sebroeck <[email protected]> Patch : http://lkml.org/lkml/2007/7/29/235 Status : patch available
Quoted 3 lines
[WATCHDOG] Fix
pcwd_init_modulecrashSigned-off-by Wim Van Sebroeck <[email protected]>
Ingo