Remove Makefile wrappers in XFS

PATCH Andi Kleen 2 participants 2 messages Jul 23, 2007 XFS filesystem

Share & tools

Andi Kleen

author

2007-07-23 09:00 UTC #0 lore raw

Makefile (and Kbuild) would include Makefile-linux-26
I doubt XFS will really still compile on 2.4; so drop that. This moves Makefile-linux-26 into Makefile and drops Kbuild. Also having wrappers as both Kbuild and Makefile seemed redundant anyways.

The patch is relatively large because it renames a file, but no functional changes.

Signed-off-by Andi Kleen <[email protected]>

fs/xfs/Kbuild deleted +0 -6

Index: linux-2.6.23-rc1-misc/fs/xfs/Kbuild
===================================================================
@@ -1,6 +0,0 @@
-#
-# The xfs people like to share Makefile with 2.6 and 2.4.
-# Utilise file named Kbuild file which has precedence over Makefile.
-#
-
-include $(srctree)/$(obj)/Makefile-linux-2.6

fs/xfs/Makefile +121 -1

122 lines not on this page · raw message

fs/xfs/Makefile-linux-2.6 deleted +0 ~~-121~~

121 lines not on this page · raw message

Eric Sandeen

2007-07-23 13:58 UTC #1 lore raw

Quoted 12 lines · Andi Kleen

Makefile (and Kbuild) would include Makefile-linux-26
I doubt XFS will really still compile on 2.4; so drop that. This moves Makefile-linux-26 into Makefile and drops Kbuild. Also having wrappers as both Kbuild and Makefile seemed redundant anyways.
The patch is relatively large because it renames a file, but no functional changes.
Signed-off-by Andi Kleen <[email protected]>

fs/xfs/Makefile line 19

Quoted 2 lines

fs/xfs/Makefile +2 -0

+
+EXTRA_CFLAGS +=	 -Ifs/xfs -Ifs/xfs/linux-2.6 -funsigned-char

The other thing we should technically do is -I$(src) -I$(src)/linux-2.6 etc, I think... and a few other things like this. I've been sitting on that patch for ages, should send it in... will do soon.

-Eric