Skip to contentSkip to conversation

pxa timer code broken for non-CONFIG_GENERIC_CLOCKEVENTS

DISCUSSION Robert Schwebel 3 participants 4 messages Jul 24, 2007

lore
Share & tools
lore
#0 lore raw

Bill,

7bbb18c9f4783b6fb3bf27af71625b590cf4f00b aka 4507/1 intensively uses stuff from include/linux/clockchips.h which are defined under

#ifdef CONFIG_GENERIC_CLOCKEVENTS

Unless I'm missing something, all PXA platforms which have CONFIG_GENERIC_CLOCKEVENTS not set are currently broken and don't compile any more.

Robert

Signature · 5 lines
 Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry
   Handelsregister:  Amtsgericht Hildesheim, HRA 2686
     Hannoversche Str. 2, 31134 Hildesheim, Germany
   Phone: +49-5121-206917-0 |  Fax: +49-5121-206917-9
#1 lore raw
Quoted 10 lines · Robert Schwebel

Bill,

7bbb18c9f4783b6fb3bf27af71625b590cf4f00b aka 4507/1 intensively uses stuff from include/linux/clockchips.h which are defined under

#ifdef CONFIG_GENERIC_CLOCKEVENTS

Unless I'm missing something, all PXA platforms which have CONFIG_GENERIC_CLOCKEVENTS not set are currently broken and don't compile any more.

I'm not sure what the point of this message is. You'll find a fix for this on linux-arm-kernel since yesterday morning.

Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
#2 lore raw
Quoted 9 lines · Russell King
Quoted 7 lines · Robert Schwebel

Bill,

7bbb18c9f4783b6fb3bf27af71625b590cf4f00b aka 4507/1 intensively uses stuff from include/linux/clockchips.h which are defined under

#ifdef CONFIG_GENERIC_CLOCKEVENTS

Quoted 9 lines
Quoted 4 lines

Unless I'm missing something, all PXA platforms which have CONFIG_GENERIC_CLOCKEVENTS not set are currently broken and don't compile any more.

I'm not sure what the point of this message is. You'll find a fix for this on linux-arm-kernel since yesterday morning.

4526/1.

b.g.

Signature · 2 lines
Bill Gatliff
[email protected]
#3 lore raw
In reply to Russell King
Quoted 2 lines · Russell King

You'll find a fix for this on linux-arm-kernel since yesterday morning.

I accidentally left this out of the patch that made it into the database (and someone else caught my mistake and posted it on l-a-k yesterday):

=== modified file 'arch/arm/Kconfig'

linux-2.6.22-arm-pxa-clockevents/arch/arm/Kconfig 2007-07-12 20:04:51 +0000 renamed from arm/Kconfig 2007-05-30 13:30:58 +0000 +1 -0
@@ -331,6 +331,7 @@
       select ARCH_MTD_XIP
       select GENERIC_GPIO
       select GENERIC_TIME
+       select GENERIC_CLOCKEVENTS
       help
         Support for Intel's PXA2XX processor line.
 

Sorry!

b.g.

Signature · 2 lines
Bill Gatliff
[email protected]