Skip to contentSkip to conversation

usb/atm: fix Kconfig garbage

PATCH In review Borislav Petkov 3 participants 5 messages Jul 23, 2007 – Jul 24, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb/atm: fix Kconfig garbage

Hi there,

I don't know whether this is the proper Kconfig-way to fix this but it works ok here.

----
When entered, the menu point "USB DSL modem support" in menuconfig, path [Device Drivers->USB Support] shows no entries but "^@" instead. The following fixes it.

--

drivers/usb/atm/Kconfig renamed from drivers/usb/atm/Kconfig.orig +2 -1
@@ -7,7 +7,8 @@ menu "USB DSL modem support"
 
 config USB_ATM
 	tristate "USB DSL modem support"
-	depends on USB && ATM
+	depends on USB
+	select ATM
 	select CRC32
 	default n
 	help
Signature · 2 lines
Regards/Gruß,
    Boris.
#1 lore raw
Quoted 14 lines · Borislav Petkov

Hi there,

I don't know whether this is the proper Kconfig-way to fix this but it works ok here.

----
When entered, the menu point "USB DSL modem support" in menuconfig, path [Device Drivers->USB Support] shows no entries but "^@" instead. The following fixes it.

--

drivers/usb/atm/Kconfig menu "USB DSL modem support" · line 14

Quoted 9 lines
drivers/usb/atm/Kconfig renamed from drivers/usb/atm/Kconfig.orig +2 -1
@@ -7,7 +7,8 @@ menu "USB DSL modem support"
 
 config USB_ATM
 	tristate "USB DSL modem support"
-	depends on USB && ATM
+	depends on USB
+	select ATM
 	select CRC32
 	default n
 	help

This would break the compilation with CONFIG_NET=n.

Quoted 2 lines

Regards/Gruß,
Boris.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#2 lore raw
Quoted 16 lines · Adrian Bunk
Quoted 15 lines · Borislav Petkov

Hi there,

I don't know whether this is the proper Kconfig-way to fix this but it works ok here.

----
When entered, the menu point "USB DSL modem support" in menuconfig, path [Device Drivers->USB Support] shows no entries but "^@" instead. The following fixes it.

--

drivers/usb/atm/Kconfig renamed from drivers/usb/atm/Kconfig.orig +0 -0
@@ -7,7 +7,8 @@ menu "USB DSL modem support"
 
Quoted 10 lines

drivers/usb/atm/Kconfig menu "USB DSL modem support" · line 14

Quoted 8 lines
drivers/usb/atm/Kconfig renamed from drivers/usb/atm/Kconfig.orig +2 -1
 config USB_ATM
 	tristate "USB DSL modem support"
-	depends on USB && ATM
+	depends on USB
+	select ATM
 	select CRC32
 	default n
 	help

This would break the compilation with CONFIG_NET=n.

Aha, so the logic behind it is that this submenu should be displayed in kconfig only if ATM is selected. Ok, I get it, thanks.

Signature · 2 lines
Regards/Gruß,
    Boris.
#3 lore raw
In reply to Borislav Petkov

Hi,

Quoted 2 lines

When entered, the menu point "USB DSL modem support" in menuconfig, path [Device Drivers->USB Support] shows no entries but "^@" instead. The following fixes it.

is the problem that there are no entries, or that "^@" is displayed? If there are no entries then presumably you didn't turn on ATM support.

Ciao,

Duncan.

#4 lore raw
Quoted 7 lines · Duncan Sands

Hi,

Quoted 2 lines

When entered, the menu point "USB DSL modem support" in menuconfig, path [Device Drivers->USB Support] shows no entries but "^@" instead. The following fixes it.

is the problem that there are no entries, or that "^@" is displayed? If there are no entries then presumably you didn't turn on ATM support.

I thought simply that when "^@" is displayed then something is wrong with the menu in Kconfig but the reason was that ATM was not enabled, that's all.

Signature · 2 lines
Regards/Gruß,
    Boris.