Skip to contentSkip to conversation

bsg: Fix build for CONFIG_BLOCK=n

PATCH In review Paul Mundt 4 participants 4 messages Jul 25, 2007 – Jul 26, 2007 Block layer

lore
Share & tools
lore

Paul Mundt

author
#0 lore raw

PATCH 1/1 bsg: Fix build for CONFIG_BLOCK=n

BLK_DEV_BSG was added outside of the if BLOCK check, which allows it to be enabled when CONFIG_BLOCK=n. This leads to many screenlengths of errors, starting with a parse error on the request_queue_t definition. Obviously this wasn't intended for CONFIG_BLOCK=n usage, so just move the option back in to the block.

Caught with a randconfig on sh.

Signed-off-by Paul Mundt <[email protected]>

--

 block/Kconfig |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
block/Kconfig +2 -2
index ca2ef4e..2484e0e 100644
@@ -49,8 +49,6 @@ config LSF
 
 	  If unsure, say Y.
 
-endif # BLOCK
-
 config BLK_DEV_BSG
 	bool "Block layer SG support v4 (EXPERIMENTAL)"
 	depends on EXPERIMENTAL

@@ -64,4 +62,6 @@ config BLK_DEV_BSG
 	protocols (e.g. Task Management Functions and SMP in Serial
 	Attached SCSI).
 
+endif # BLOCK
+
 source block/Kconfig.iosched
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Paul Mundt

BLK_DEV_BSG was added outside of the if BLOCK check, which allows it to be enabled when CONFIG_BLOCK=n. This leads to many screenlengths of errors, starting with a parse error on the request_queue_t definition. Obviously this wasn't intended for CONFIG_BLOCK=n usage, so just move the option back in to the block.

Caught with a randconfig on sh.

Signed-off-by Paul Mundt <[email protected]>

That's definitely correct.

Acked-by Jens Axboe <[email protected]>
Signature · 1 line
Jens Axboe
#2 lore raw
In reply to Paul Mundt

Hi,

Quoted 7 lines · Paul Mundt

BLK_DEV_BSG was added outside of the if BLOCK check, which allows it to be enabled when CONFIG_BLOCK=n. This leads to many screenlengths of errors, starting with a parse error on the request_queue_t definition. Obviously this wasn't intended for CONFIG_BLOCK=n usage, so just move the option back in to the block.

Caught with a randconfig on sh.

also pointed out in my bsg review from a week ago ;)

http://lkml.org/lkml/2007/7/17/487

Quoted 1 line
Signed-off-by Paul Mundt <[email protected]>

Thanks for fixing this up.

Bart

#3 lore raw

From: Bartlomiej Zolnierkiewicz <[email protected]>
Subject: Re: [PATCH] bsg: Fix build for CONFIG_BLOCK=n
Date: Wed, 25 Jul 2007 13:04:56 +0200

Quoted 10 lines

Hi,

Quoted 6 lines · Paul Mundt

BLK_DEV_BSG was added outside of the if BLOCK check, which allows it to be enabled when CONFIG_BLOCK=n. This leads to many screenlengths of errors, starting with a parse error on the request_queue_t definition. Obviously this wasn't intended for CONFIG_BLOCK=n usage, so just move the option back in to the block.

Quoted 5 lines
Quoted 1 line

Caught with a randconfig on sh.

also pointed out in my bsg review from a week ago ;)

http://lkml.org/lkml/2007/7/17/487

Oops, sorry.

Quoted 3 lines
Quoted 1 line
Signed-off-by Paul Mundt <[email protected]>

Thanks for fixing this up.

Thanks!