Skip to contentSkip to conversation

rt2x00: Don't export unneeded symbols

PATCH New Ivo van Doorn 1 participant 1 message Jul 25, 2007 Networking drivers (wireless)

lore
Share & tools
lore

Ivo van Doorn

author
#0 lore raw

PATCH 4/11 rt2x00: Don't export unneeded symbols

Quoted 1 line

From e26a10768af9be7b2dfe4cff4fd598647377b937 Mon Sep 17 00:00:00 2001

From: Adam Baker <[email protected]>
Date: Sun, 22 Jul 2007 22:46:55 +0100
Subject: [PATCH 04/11] [PATCH] rt2x00: Don't export unneeded symbols

The methods rt2x00lib_uninitialize and rt2x00usb_beacondone aren't used outside the files that define them. Make them static and move them earlier in the file so they are defined before first use.

This fixes the only complaints "make namespacecheck" has with the rt2x00 drivers.

Signed-off-by Adam Baker <[email protected]>
Signed-off-by Ivo van Doorn <[email protected]>
---
 drivers/net/wireless/mac80211/rt2x00/rt2x00dev.c |   41 ++++++++-------
 drivers/net/wireless/mac80211/rt2x00/rt2x00dev.h |    1 -
 drivers/net/wireless/mac80211/rt2x00/rt2x00usb.c |   60 +++++++++++-----------
 drivers/net/wireless/mac80211/rt2x00/rt2x00usb.h |    1 -
 4 files changed, 51 insertions(+), 52 deletions(-)
drivers/net/wireless/mac80211/rt2x00/rt2x00dev.c +21 -20
index f4fedeb..b8c3f7b 100644
@@ -749,6 +749,27 @@ static void rt2x00lib_free_ring_entries(struct rt2x00_dev *rt2x00dev)
 	}
 }
 
+static void rt2x00lib_uninitialize(struct rt2x00_dev *rt2x00dev)
+{
+	if (!__test_and_clear_bit(DEVICE_INITIALIZED, &rt2x00dev->flags))
+		return;
+
+	/*
+	 * Unregister rfkill.
+	 */
+	rt2x00lib_unregister_rfkill(rt2x00dev);
+
+	/*
+	 * Allow the HW to uninitialize.
+	 */
+	rt2x00dev->ops->lib->uninitialize(rt2x00dev);
+
+	/*
+	 * Free allocated ring entries.
+	 */
+	rt2x00lib_free_ring_entries(rt2x00dev);
+}
+
 int rt2x00lib_initialize(struct rt2x00_dev *rt2x00dev)
 {
 	int status;

@@ -792,26 +813,6 @@ exit:
 	return status;
 }
 
-void rt2x00lib_uninitialize(struct rt2x00_dev *rt2x00dev)
-{
-	if (!__test_and_clear_bit(DEVICE_INITIALIZED, &rt2x00dev->flags))
-		return;
-
-	/*
-	 * Unregister rfkill.
-	 */
-	rt2x00lib_unregister_rfkill(rt2x00dev);
-
-	/*
-	 * Allow the HW to uninitialize.
-	 */
-	rt2x00dev->ops->lib->uninitialize(rt2x00dev);
-
-	/*
-	 * Free allocated ring entries.
-	 */
-	rt2x00lib_free_ring_entries(rt2x00dev);
-}
 
 /*
  * driver allocation handlers.
drivers/net/wireless/mac80211/rt2x00/rt2x00dev.h +0 -1
index ee0bbfe..c6feee3 100644
@@ -43,7 +43,6 @@ void rt2x00lib_toggle_rx(struct rt2x00_dev *rt2x00dev, int enable);
  * Initialization/uninitialization handlers.
  */
 int rt2x00lib_initialize(struct rt2x00_dev *rt2x00dev);
-void rt2x00lib_uninitialize(struct rt2x00_dev *rt2x00dev);
 
 /*
  * Config handlers.
drivers/net/wireless/mac80211/rt2x00/rt2x00usb.c +30 -30

72 lines not on this page · raw message

drivers/net/wireless/mac80211/rt2x00/rt2x00usb.h +0 -1
index 91627f2..c59d5db 100644
@@ -103,7 +103,6 @@ void rt2x00usb_disable_radio(struct rt2x00_dev *rt2x00dev);
  */
 int rt2x00usb_beacon_update(struct ieee80211_hw *hw, struct sk_buff *skb,
 	struct ieee80211_tx_control *control);
-void rt2x00usb_beacondone(struct urb *urb);
 
 /*
  * TX data handlers.
Signature · 1 line
1.5.2.2