Skip to contentSkip to conversation

ACPI patches for 2.6.23-rc1

PATCH Al Boldi 3 participants 4 messages Jul 25, 2007 – Jul 26, 2007

lore
Share & tools
lore

Al Boldi

author
#0 lore raw
Quoted 9 lines · Linus Torvalds
Quoted 7 lines · Len Brown

git://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux-acpi-2.6.git
release

Fixes regressions -- a build failure, an oops, some dmesg spam. Also fixes some D-state issues and adds ACPI module auto-loading. Yes, I'd hoped to get the last two in before rc1.
I'm hopeful that a couple-days into rc2 is sufficiently early for them.

Quoted 5 lines

I hate pulling this, but I did. However, what I hate even more after having done so is that ACPI now seems to select CPU hotplug. Why?

That is just *broken*. Sure, if you select STR or hibernation, we need CPU hotplug,

You are kidding, right? CPU hotplug is broken big time; it kills a machine like virus-scanner. I always turn it of as a rule. And now you want STR/STD to be dependent on it? Even on UP? Why?

Thanks!

--
Al

#1 lore raw
Quoted 13 lines · Al Boldi
Quoted 12 lines · Linus Torvalds
Quoted 7 lines · Len Brown

git://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux-acpi-2.6.git
release

Fixes regressions -- a build failure, an oops, some dmesg spam. Also fixes some D-state issues and adds ACPI module auto-loading. Yes, I'd hoped to get the last two in before rc1.
I'm hopeful that a couple-days into rc2 is sufficiently early for them.

I hate pulling this, but I did. However, what I hate even more after having done so is that ACPI now seems to select CPU hotplug. Why?

Quoted 6 lines
Quoted 2 lines

That is just *broken*. Sure, if you select STR or hibernation, we need CPU hotplug,

You are kidding, right? CPU hotplug is broken big time; it kills a machine like virus-scanner. I always turn it of as a rule. And now you want STR/STD to be dependent on it? Even on UP? Why?

CPU_HOTPLUG is needed to take the non-boot processors off-line before the suspend, and to bring them on-line upon the resume. If you have specific problems with bringing logical processors offline and online, then please speak up because many are depending on this functionality working.

SMP system sleep support has always depended on CPU_HOTPLUG, per above.

No, uniprocessor system sleep does not depend on CPU_HOTPLUG.

-Len

#2 lore raw
Quoted 17 lines · Len Brown
Quoted 16 lines · Al Boldi
Quoted 14 lines · Linus Torvalds
Quoted 7 lines · Len Brown

git://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux-acpi-2.6.git
release

Fixes regressions -- a build failure, an oops, some dmesg spam. Also fixes some D-state issues and adds ACPI module auto-loading. Yes, I'd hoped to get the last two in before rc1.
I'm hopeful that a couple-days into rc2 is sufficiently early for them.

I hate pulling this, but I did. However, what I hate even more after having done so is that ACPI now seems to select CPU hotplug. Why?

That is just *broken*. Sure, if you select STR or hibernation, we need CPU hotplug,

Quoted 8 lines
Quoted 3 lines

You are kidding, right? CPU hotplug is broken big time; it kills a machine like virus-scanner. I always turn it of as a rule. And now you want STR/STD to be dependent on it? Even on UP? Why?

CPU_HOTPLUG is needed to take the non-boot processors off-line before the suspend, and to bring them on-line upon the resume. If you have specific problems with bringing logical processors offline and online, then please speak up because many are depending on this functionality working.

nobody is arguing that CPU_HOTPLUG should not be a requirement for suspend, what we are questioning is why simply enabling ACPI should require CPU_HOTPLUG.

not everyone who configures ACPI wants to use suspend (of any flavor)

David Lang

author
#3 lore raw
Quoted 29 lines · [email protected] wrote:
Quoted 22 lines · Len Brown
Quoted 14 lines · Al Boldi
Quoted 13 lines · Linus Torvalds
Quoted 8 lines · Len Brown

git://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux-acpi-2.6.git
release

Fixes regressions -- a build failure, an oops, some dmesg spam. Also fixes some D-state issues and adds ACPI module auto-loading. Yes, I'd hoped to get the last two in before rc1.
I'm hopeful that a couple-days into rc2 is sufficiently early for them.

I hate pulling this, but I did. However, what I hate even more after having done so is that ACPI now seems to select CPU hotplug. Why?

Quoted 6 lines
Quoted 2 lines

That is just *broken*. Sure, if you select STR or hibernation, we need CPU hotplug,

You are kidding, right? CPU hotplug is broken big time; it kills a machine like virus-scanner. I always turn it of as a rule. And now you want STR/STD to be dependent on it? Even on UP? Why?

Quoted 5 lines

CPU_HOTPLUG is needed to take the non-boot processors off-line before the suspend, and to bring them on-line upon the resume. If you have specific problems with bringing logical processors offline and online, then please speak up because many are depending on this functionality working.

Quoted 5 lines

nobody is arguing that CPU_HOTPLUG should not be a requirement for suspend, what we are questioning is why simply enabling ACPI should require CPU_HOTPLUG.

not everyone who configures ACPI wants to use suspend (of any flavor)

Actually, I would go one step further and just rip out hotplug from the kernel proper, and let userland handle it. Really, just like devfs, hotplug has no place in the kernel.

Thanks!

--
Al