Skip to contentSkip to conversation

MAINTAINERS: use relevant mailing lists

PATCH In review Randy Dunlap 3 participants 5 messages Jul 27, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: use relevant mailing lists

From: Randy Dunlap <[email protected]>

Add text on using relevant mailing lists.

---
 MAINTAINERS |   13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)
MAINTAINERS +8 -5
@@ -23,15 +23,18 @@ trivial patch so apply some common sense
 4.	When you are happy with a change make it generally available for
 	testing and await feedback.
 
-5.	Make a patch available to the relevant maintainer in the list. Use
-	'diff -u' to make the patch easy to merge. Be prepared to get your
-	changes sent back with seemingly silly requests about formatting
-	and variable names.  These aren't as silly as they seem. One
-	job the maintainers (and especially Linus) do is to keep things
+5.	Make a patch available to the relevant maintainer(s) and mailing
+	list(s). Use 'diff -u' to make the patch easy to merge. Be prepared
+	to get your changes sent back with seemingly silly requests about
+	formatting and variable names.  These aren't as silly as they seem.
+	One job the maintainers (and especially Linus) do is to keep things
 	looking the same. Sometimes this means that the clever hack in
 	your driver to get around a problem actually needs to become a
 	generalized kernel feature ready for next time.
 
+	Use the relevant mailing list(s) -- don't just send everything to
+	lkml ([email protected]).
+
 	PLEASE check your patch with the automated style checker
 	(scripts/checkpatch.pl) to catch trival style violations.
 	See Documentation/CodingStyle for guidance here.
#1 lore raw
Quoted 4 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Add text on using relevant mailing lists.

I'd add a little bit to that - see below

Quoted 17 lines
---
 MAINTAINERS |   13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)
MAINTAINERS +1 -5
@@ -23,15 +23,18 @@ trivial patch so apply some common sense
 4.     When you are happy with a change make it generally available for
        testing and await feedback.
 
-5.     Make a patch available to the relevant maintainer in the list. Use
-       'diff -u' to make the patch easy to merge. Be prepared to get your
-       changes sent back with seemingly silly requests about formatting
-       and variable names.  These aren't as silly as they seem. One
-       job the maintainers (and especially Linus) do is to keep things
+5.     Make a patch available to the relevant maintainer(s) and mailing

MAINTAINERS trivial patch so apply some common sense · line 36

Quoted 10 lines
MAINTAINERS +6 -0
+       list(s). Use 'diff -u' to make the patch easy to merge. Be prepared
+       to get your changes sent back with seemingly silly requests about
+       formatting and variable names.  These aren't as silly as they seem.
+       One job the maintainers (and especially Linus) do is to keep things
        looking the same. Sometimes this means that the clever hack in
        your driver to get around a problem actually needs to become a
        generalized kernel feature ready for next time.
 
+       Use the relevant mailing list(s) -- don't just send everything to
+       lkml ([email protected]).

+ Always including lkml in addition to more specific lists is usually OK.

Quoted 4 lines
MAINTAINERS +1 -0
+
        PLEASE check your patch with the automated style checker
        (scripts/checkpatch.pl) to catch trival style violations.
        See Documentation/CodingStyle for guidance here.
Signature · 3 lines
Jesper Juhl <[email protected]>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
#2 lore raw
Quoted 38 lines · Jesper Juhl
Quoted 4 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Add text on using relevant mailing lists.

I'd add a little bit to that - see below

Quoted 30 lines
---
 MAINTAINERS |   13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)
MAINTAINERS +0 -1
@@ -23,15 +23,18 @@ trivial patch so apply some common sense
 4.     When you are happy with a change make it generally available for
        testing and await feedback.
 
-5.     Make a patch available to the relevant maintainer in the list. 

Use
- 'diff -u' to make the patch easy to merge. Be prepared to get
your

MAINTAINERS +2 -3
-       changes sent back with seemingly silly requests about formatting
-       and variable names.  These aren't as silly as they seem. One
-       job the maintainers (and especially Linus) do is to keep things
+5.     Make a patch available to the relevant maintainer(s) and mailing
+       list(s). Use 'diff -u' to make the patch easy to merge. Be 

prepared

MAINTAINERS +2 -0
+       to get your changes sent back with seemingly silly requests about
+       formatting and variable names.  These aren't as silly as they 

seem.
+ One job the maintainers (and especially Linus) do is to keep
things
looking the same. Sometimes this means that the clever hack in your driver to get around a problem actually needs to become a generalized kernel feature ready for next time.

Quoted 5 lines

MAINTAINERS trivial patch so apply some common sense · line 36

Quoted 2 lines
MAINTAINERS +2 -0
+       Use the relevant mailing list(s) -- don't just send everything to
+       lkml ([email protected]).

+ Always including lkml in addition to more specific lists is
usually OK.

Well, I'd rather not say that, but that's the type of discussion that this patch was looking for..

Quoted 4 lines
Quoted 4 lines

+
PLEASE check your patch with the automated style checker (scripts/checkpatch.pl) to catch trival style violations. See Documentation/CodingStyle for guidance here.

Thanks.

Signature · 2 lines
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
#3 lore raw
In reply to Randy Dunlap

MAINTAINERS trivial patch so apply some common sense · line 36

Quoted 2 lines · On Thu, 26 Jul 2007 17:08:57 -0700 Randy Dunlap <[email protected]> wrote:
MAINTAINERS +2 -0
+	Use the relevant mailing list(s) -- don't just send everything to
+	lkml ([email protected]).

True.

I personally only troll lkml for unloved patches, so I suspect that a random patch which is sent to mailing-list-A and not to lkml has a higher probability of getting lost than one which is sent to both lists. Plus it'd be nice to get lkml's patch-to-noise ratio above one percent.

So I'd suggest that you rework the text here to make it clearer that patches should go to lkml _and_ to the subsystem-specific mailing list.

#4 lore raw
Quoted 11 lines · On Thu, 26 Jul 2007 17:31:40 -0700 Andrew Morton wrote:

MAINTAINERS trivial patch so apply some common sense · line 36

Quoted 2 lines · On Thu, 26 Jul 2007 17:08:57 -0700 Randy Dunlap <[email protected]> wrote:
MAINTAINERS +2 -0
+	Use the relevant mailing list(s) -- don't just send everything to
+	lkml ([email protected]).

True.

I personally only troll lkml for unloved patches, so I suspect that a random patch which is sent to mailing-list-A and not to lkml has a higher probability of getting lost than one which is sent to both lists. Plus it'd be nice to get lkml's patch-to-noise ratio above one percent.

Yes (to P-N ratio).

I'd really like to see netdev patches going to netdev (only :) and SCSI patches to linux-scsi (only), e.g., unless they actually address some linux-arch like issue(s).

However, those maintainers are quite different regarding patch handling. Maybe you could try to address some of that at that Cambridge/September event.

Quoted 2 lines

So I'd suggest that you rework the text here to make it clearer that patches should go to lkml _and_ to the subsystem-specific mailing list.

Patch is withdrawn.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***