Skip to contentSkip to conversation

arch/powerpc/Kconfig: fix the EMBEDDED6xx dependencies

PATCH NAK Adrian Bunk 3 participants 4 messages Dec 1, 2006 – Jul 29, 2007 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arch/powerpc/Kconfig: fix the EMBEDDED6xx dependencies

This patch changes the EMBEDDED6xx dependencies to the equivalent dependency that seems to have been intended.

---

This patch was already sent on:
- 22 Nov 2006

arch/powerpc/Kconfig renamed from arch/powerpc/Kconfig.old +1 -1
@@ -369,7 +369,7 @@ config PPC_MULTIPLATFORM
 
 config EMBEDDED6xx
 	bool "Embedded 6xx/7xx/7xxx-based board"
-	depends on PPC32 && (BROKEN||BROKEN_ON_SMP)
+	depends on PPC32 && BROKEN_ON_SMP
 
 config APUS
 	bool "Amiga-APUS"
#1 lore raw
Quoted 2 lines · Adrian Bunk

This patch changes the EMBEDDED6xx dependencies to the equivalent dependency that seems to have been intended.

Nack - CONFIG_EMBEDDED6xx is going away entirely, soon.

Paul.

#2 lore raw
Quoted 6 lines · Paul Mackerras
Quoted 2 lines · Adrian Bunk

This patch changes the EMBEDDED6xx dependencies to the equivalent dependency that seems to have been intended.

Nack - CONFIG_EMBEDDED6xx is going away entirely, soon.

Still there - and still with this strange dependency.

Quoted 1 line

Paul.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#3 lore raw
Quoted 9 lines · Adrian Bunk
Quoted 6 lines · Paul Mackerras
Quoted 2 lines · Adrian Bunk

This patch changes the EMBEDDED6xx dependencies to the equivalent dependency that seems to have been intended.

Nack - CONFIG_EMBEDDED6xx is going away entirely, soon.

Still there - and still with this strange dependency.

The last time I sent my patch to clean up CONFIG_EMBEDDED6xx and a few other Kconfig options I still left it intact, but it becomes unnecessary after that.

I still think that having high-level options like

* embedded6xx
* MPC7448HPC2
* holly
* linkstation
* PPC_83xx
* MPC8313_RDB
* MPC832x_MDS
* MPC832x_RDB

helps keep the platform selection more structured and readable, but the dependency on !SMP should probably go into the individual platforms that are actually broken, if any, not into the high-level option.

	Arnd <><