Skip to contentSkip to conversation

make abituguru3_read_increment_offset() static

PATCH In review Adrian Bunk 3 participants 3 messages Jul 29, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 make abituguru3_read_increment_offset() static

abituguru3_read_increment_offset() can become static.

---

drivers/hwmon/abituguru3.c renamed from drivers/hwmon/abituguru3.c.old +3 -2
@@ -691,8 +691,9 @@
 
 /* Sensor settings are stored 1 byte per offset with the bytes
    placed add consecutive offsets. */
-int abituguru3_read_increment_offset(struct abituguru3_data *data, u8 bank,
-	u8 offset, u8 count, u8 *buf, int offset_count)
+static int abituguru3_read_increment_offset(struct abituguru3_data *data,
+					    u8 bank, u8 offset, u8 count,
+					    u8 *buf, int offset_count)
 {
 	int i, x;
 

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · Adrian Bunk

abituguru3_read_increment_offset() can become static.

Looks good, good catch.

Quoted 18 lines

---

drivers/hwmon/abituguru3.c renamed from drivers/hwmon/abituguru3.c.old +3 -2
@@ -691,8 +691,9 @@
 
 /* Sensor settings are stored 1 byte per offset with the bytes
    placed add consecutive offsets. */
-int abituguru3_read_increment_offset(struct abituguru3_data *data, u8 bank,
-	u8 offset, u8 count, u8 *buf, int offset_count)
+static int abituguru3_read_increment_offset(struct abituguru3_data *data,
+					    u8 bank, u8 offset, u8 count,
+					    u8 *buf, int offset_count)
 {
 	int i, x;
 
Quoted 5 lines

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#2 lore raw

Hi:

Quoted 17 lines · Hans de Goede
Quoted 3 lines · Adrian Bunk

abituguru3_read_increment_offset() can become static.

Looks good, good catch.

Quoted 8 lines

---
--- linux-2.6.23-rc1-mm1/drivers/hwmon/abituguru3.c.old 2007-07-26
08:56:33.000000000 +0200
+++ linux-2.6.23-rc1-mm1/drivers/hwmon/abituguru3.c 2007-07-26
08:57:00.000000000 +0200

(quoted diff) +0 -0
@@ -691,8 +691,9 @@
 
Quoted 12 lines

drivers/hwmon/abituguru3.c line 698

Quoted 12 lines
drivers/hwmon/abituguru3.c renamed from drivers/hwmon/abituguru3.c.old +3 -2
 /* Sensor settings are stored 1 byte per offset with the bytes
   placed add consecutive offsets. */
-int abituguru3_read_increment_offset(struct abituguru3_data *data, u8 
 bank,
-	u8 offset, u8 count, u8 *buf, int offset_count)
+static int abituguru3_read_increment_offset(struct abituguru3_data *data,
+					    u8 bank, u8 offset, u8 count,
+					    u8 *buf, int offset_count)
 {
 	int i, x;

Applied to hwmon-2.6.git/testing, thanks.

Signature · 8 lines
Mark M. Hoffman
[email protected]


_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors