Skip to contentSkip to conversation

make kernel/power/main.c:suspend_enter() static

PATCH In review Adrian Bunk 2 participants 3 messages Jul 29, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 make kernel/power/main.c:suspend_enter() static

suspend_enter() can now become static.

---

 kernel/power/main.c  |    2 +-
 kernel/power/power.h |    1 -
 2 files changed, 1 insertion(+), 2 deletions(-)
kernel/power/power.h renamed from kernel/power/power.h.old +0 -1
@@ -177,7 +177,6 @@
 				unsigned int, char *);
 
 /* kernel/power/main.c */
-extern int suspend_enter(suspend_state_t state);
 extern int suspend_devices_and_enter(suspend_state_t state);
 extern struct blocking_notifier_head pm_chain_head;
 
kernel/power/main.c renamed from kernel/power/main.c.old +1 -1
@@ -120,7 +120,7 @@
  *
  *	This function should be called after devices have been suspended.
  */
-int suspend_enter(suspend_state_t state)
+static int suspend_enter(suspend_state_t state)
 {
 	int error = 0;
 
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Adrian Bunk

suspend_enter() can now become static.

---

Quoted 28 lines
 kernel/power/main.c  |    2 +-
 kernel/power/power.h |    1 -
 2 files changed, 1 insertion(+), 2 deletions(-)
kernel/power/power.h renamed from kernel/power/power.h.old +0 -1
@@ -177,7 +177,6 @@
 				unsigned int, char *);
 
 /* kernel/power/main.c */
-extern int suspend_enter(suspend_state_t state);
 extern int suspend_devices_and_enter(suspend_state_t state);
 extern struct blocking_notifier_head pm_chain_head;
 
kernel/power/main.c renamed from kernel/power/main.c.old +1 -1
@@ -120,7 +120,7 @@
  *
  *	This function should be called after devices have been suspended.
  */
-int suspend_enter(suspend_state_t state)
+static int suspend_enter(suspend_state_t state)
 {
 	int error = 0;
 
Signature · 1 line
"Premature optimization is the root of all evil." - Donald Knuth
Acked-by on v1 1/1
#2 lore raw
In reply to Adrian Bunk
Quoted 5 lines · Adrian Bunk

suspend_enter() can now become static.

---

Quoted 28 lines
 kernel/power/main.c  |    2 +-
 kernel/power/power.h |    1 -
 2 files changed, 1 insertion(+), 2 deletions(-)
kernel/power/power.h renamed from kernel/power/power.h.old +0 -1
@@ -177,7 +177,6 @@
 				unsigned int, char *);
 
 /* kernel/power/main.c */
-extern int suspend_enter(suspend_state_t state);
 extern int suspend_devices_and_enter(suspend_state_t state);
 extern struct blocking_notifier_head pm_chain_head;
 
kernel/power/main.c renamed from kernel/power/main.c.old +1 -1
@@ -120,7 +120,7 @@
  *
  *	This function should be called after devices have been suspended.
  */
-int suspend_enter(suspend_state_t state)
+static int suspend_enter(suspend_state_t state)
 {
 	int error = 0;
 
Signature · 1 line
"Premature optimization is the root of all evil." - Donald Knuth