Skip to contentSkip to conversation

drivers/scsi/imm.c: fix check-after-use

PATCH New Adrian Bunk 1 participant 1 message Jul 30, 2007 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/scsi/imm.c: fix check-after-use

The Coverity checker spotted that we have already oops'ed if "cmd" was NULL.

Since "cmd" being NULL doesn't seem to be possible at this point this patch removes the NULL check.

---

drivers/scsi/imm.c renamed from drivers/scsi/imm.c.old +0 -4
@@ -740,10 +740,6 @@ static void imm_interrupt(struct work_st
 	struct Scsi_Host *host = cmd->device->host;
 	unsigned long flags;
 
-	if (!cmd) {
-		printk("IMM: bug in imm_interrupt\n");
-		return;
-	}
 	if (imm_engine(dev, cmd)) {
 		schedule_delayed_work(&dev->imm_tq, 1);
 		return;