usbat_check_status(): fix check-after-use
Subsystems (2)
PATCH 1/1 usbat_check_status(): fix check-after-use
The Coverity checker spotted that we have already oops'ed if "us" was NULL.
Since "us" can't be NULL in the only caller this patch removes the NULL check.
Signed-off-by Adrian Bunk <[email protected]>
---
drivers/usb/storage/shuttle_usbat.c renamed from drivers/usb/storage/shuttle_usbat.c.old +0 -3
@@ -190,9 +190,6 @@ static int usbat_check_status(struct us_unsigned char *reply = us->iobuf;int rc; -if (!us) -return USB_STOR_TRANSPORT_ERROR ; - rc =usbat_get_status (us, reply);if (rc !=USB_STOR_XFER_GOOD )return USB_STOR_TRANSPORT_FAILED ;
Signed-off-by Matthew Dharm <[email protected]>
Quoted 21 lines · Adrian Bunk
The Coverity checker spotted that we have already oops'ed if "us" was NULL.
Since "us" can't be NULL in the only caller this patch removes the NULL check.
Signed-off-by Adrian Bunk <[email protected]>---
drivers/usb/storage/shuttle_usbat.c renamed from drivers/usb/storage/shuttle_usbat.c.old +0
-3@@ -190,9 +190,6 @@ static int usbat_check_status(struct us_unsigned char *reply = us->iobuf;int rc; -if (!us) -return USB_STOR_TRANSPORT_ERROR ; - rc =usbat_get_status (us, reply);if (rc !=USB_STOR_XFER_GOOD )return USB_STOR_TRANSPORT_FAILED ;
Signature · 6 lines
Matthew Dharm Home: [email protected] Maintainer, Linux USB Mass Storage Driver I need a computer? -- Customer User Friendly, 2/19/1998