Mention libiconv as a requirement for git-am
PATCH 1/1 Mention libiconv as a requirement for git-am
---
Han-Wen, any chance to include libiconv to the installer? You may need to set NEEDS_ICONV, ICONVDIR and NO_ICONV properly to make git-am work.
README.MinGW | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
README.MinGW +1 -0
@@ -28,6 +28,7 @@ In order to compile this code you need: zlib-1.2.3-mingwPORT-1.tar w32api-3.6.tar.gz tcltk-8.4.1-1.exe (for gitk, git-gui) + libiconv-1.9.2-1-{lib,bin}.zip (for git-am, from http://gnuwin32.sourceforge.net/packages/libiconv.htm) STATUS
Signature · 1 line
1.5.0.7
libiconv is already in there, version 1.11,
[lilydev@haring gub]$ grep bin.libiconv target/mingw/gubfiles/installer-git-master-repo.or.cz-git-mingw.git/files.txt \usr\bin\libiconv-2.dll
I don't understand your request: do you want to have some flags added to the environment?
2007/7/31, Nguyen Thai Ngoc Duy <[email protected]>:
Quoted 22 lines
---
Han-Wen, any chance to include libiconv to the installer? You may need to setNEEDS_ICONV, ICONVDIR andNO_ICONVproperly to make git-am work.README.MinGW | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)README.MinGW +1
-1@@ -28,6 +28,7 @@ In order to compile this code you need: zlib-1.2.3-mingwPORT-1.tar w32api-3.6.tar.gz tcltk-8.4.1-1.exe (for gitk, git-gui) + libiconv-1.9.2-1-{lib,bin}.zip (for git-am, from http://gnuwin32.sourceforge.net/packages/libiconv.htm) STATUS --1.5.0.7
Signature · 1 line
Han-Wen Nienhuys - [email protected] - http://www.xs4all.nl/~hanwen
I'm sorry I judged by reading Makefile without actually testing your installation, so I might be wrong. By default Makefile set NO_ICONV=YesPlease on MinGW so it won't use libiconv even if it exists. You need to unset NO_ICONV and set NEEDS_LIBICONV in config.mak in order to enable it.
I'm going to test it tomorrow.
Quoted 37 lines · Han-Wen Nienhuys
libiconv is already in there, version 1.11,
[lilydev@haring gub]$ grep bin.libiconv
target/mingw/gubfiles/installer-git-master-repo.or.cz-git-mingw.git/files.txt\usr\bin\libiconv-2.dllI don't understand your request: do you want to have some flags added to the environment?
2007/7/31, Nguyen Thai Ngoc Duy <[email protected]>:
Quoted 20 lines
---
Han-Wen, any chance to include libiconv to the installer? You may need to setNEEDS_ICONV, ICONVDIR andNO_ICONVproperly to make git-am work.README.MinGW | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)README.MinGW +1
-1@@ -28,6 +28,7 @@ In order to compile this code you need: zlib-1.2.3-mingwPORT-1.tar w32api-3.6.tar.gz tcltk-8.4.1-1.exe (for gitk, git-gui) + libiconv-1.9.2-1-{lib,bin}.zip (for git-am, from http://gnuwin32.sourceforge.net/packages/libiconv.htm) STATUS --Quoted 2 lines
1.5.0.7
--
Han-Wen Nienhuys - [email protected] - http://www.xs4all.nl/~hanwen
Signature · 1 line
Duy
2007/8/1, Nguyen Thai Ngoc Duy <[email protected]>:
Quoted 5 lines
I'm sorry I judged by reading
Makefilewithout actually testing your installation, so I might be wrong. By defaultMakefileset NO_ICONV=YesPlease on MinGW so it won't use libiconv even if it exists. You need to unsetNO_ICONVand setNEEDS_LIBICONVin config.mak in order to enable it.
this is done automatically when running configure. If you find a problem with the installer please let me know.
Quoted 1 line
I'm going to test it tomorrow.
Signature · 1 line
Han-Wen Nienhuys - [email protected] - http://www.xs4all.nl/~hanwen