Skip to contentSkip to conversation

scsi_transport_srp: remove tgt dependencies

PATCH In review FUJITA Tomonori 3 participants 3 messages Aug 1, 2007 SCSI

lore
Share & tools
lore

FUJITA Tomonori

author
#0 lore raw

PATCH 1/1 scsi_transport_srp: remove tgt dependencies

Hopefully, this works. Is there an easier way to remove tgt dependencies in scsi_transport_srp?

---

Quoted 1 line

From 00924b31df30e4ddcf9ba9b5082171e5e46b9eb0 Mon Sep 17 00:00:00 2001

From: FUJITA Tomonori <[email protected]>
Date: Thu, 2 Aug 2007 00:03:11 +0900
Subject: [PATCH] scsi_transport_srp: remove tgt dependencies

it's better to remove tgt dependencies in srp transport class since most people want only initiator support.

Signed-off-by FUJITA Tomonori <[email protected]>
---
 drivers/scsi/Kconfig                       |   11 +++++++++--
 drivers/scsi/scsi_transport_srp.c          |   10 +++++-----
 drivers/scsi/scsi_transport_srp_internal.h |   25 +++++++++++++++++++++++++
 3 files changed, 39 insertions(+), 7 deletions(-)
 create mode 100644 drivers/scsi/scsi_transport_srp_internal.h
drivers/scsi/Kconfig +9 -2
index 4562273..7877dfd 100644
@@ -291,11 +291,18 @@ source "drivers/scsi/libsas/Kconfig"
 
 config SCSI_SRP_ATTRS
 	tristate "SRP Transport Attributes"
-	depends on SCSI && SCSI_TGT
+	depends on SCSI
 	help
 	  If you wish to export transport-specific information about
 	  each attached SRP device to sysfs, say Y.
 
+config SCSI_SRP_TGT_ATTRS
+	bool "SCSI target support for SRP Transport Attributes"
+	depends on SCSI_SRP_ATTRS
+	depends on SCSI_TGT = y || SCSI_TGT = SCSI_SRP_ATTRS
+	help
+		If you want to use SCSI target mode drivers enable this option.
+
 endmenu
 
 menuconfig SCSI_LOWLEVEL

@@ -848,7 +855,7 @@ config SCSI_IBMVSCSI
 
 config SCSI_IBMVSCSIS
 	tristate "IBM Virtual SCSI Server support"
-	depends on PPC_PSERIES && SCSI_TGT && SCSI_SRP && SCSI_SRP_ATTRS
+	depends on PPC_PSERIES && SCSI_SRP && SCSI_SRP_TGT_ATTRS
 	help
 	  This is the SRP target driver for IBM pSeries virtual environments.
drivers/scsi/scsi_transport_srp.c +5 -5
index cdd001a..430501e 100644
@@ -30,7 +30,7 @@
 #include <scsi/scsi_host.h>
 #include <scsi/scsi_transport.h>
 #include <scsi/scsi_transport_srp.h>
-#include <scsi/scsi_tgt.h>
+#include "scsi_transport_srp_internal.h"
 
 struct srp_host_attrs {
 	atomic_t next_port_id;

@@ -223,8 +223,8 @@ struct srp_rport *srp_rport_add(struct Scsi_Host *shost,
 	}
 
 	if (ids->roles == SRP_RPORT_ROLE_INITIATOR) {
-		ret = scsi_tgt_it_nexus_create(shost, (unsigned long)rport,
-					       rport->port_id);
+		ret = srp_tgt_it_nexus_create(shost, (unsigned long)rport,
+					      rport->port_id);
 		if (ret) {
 			device_del(&rport->dev);
 			transport_destroy_device(&rport->dev);

@@ -251,8 +251,8 @@ void srp_rport_del(struct srp_rport *rport)
 	struct device *dev = &rport->dev;
 
 	if (rport->roles == SRP_RPORT_ROLE_INITIATOR)
-		scsi_tgt_it_nexus_destroy(dev_to_shost(dev->parent),
-					  (unsigned long)rport);
+		srp_tgt_it_nexus_destroy(dev_to_shost(dev->parent),
+					 (unsigned long)rport);
 
 	transport_remove_device(dev);
 	device_del(dev);
drivers/scsi/scsi_transport_srp_internal.h new file +25 -0
new file mode 100644
index 0000000..8a79747
@@ -0,0 +1,25 @@
+#include <scsi/scsi_tgt.h>
+
+#ifdef CONFIG_SCSI_SRP_TGT_ATTRS
+static inline int srp_tgt_it_nexus_create(struct Scsi_Host *shost, u64 itn_id,
+					  char *initiator)
+{
+	return scsi_tgt_it_nexus_create(shost, itn_id, initiator);
+}
+
+static inline int srp_tgt_it_nexus_destroy(struct Scsi_Host *shost, u64 itn_id)
+{
+	return scsi_tgt_it_nexus_destroy(shost, itn_id);
+}
+
+#else
+static inline int srp_tgt_it_nexus_create(struct Scsi_Host *shost, u64 itn_id,
+					  char *initiator)
+{
+	return 0;
+}
+static inline int srp_tgt_it_nexus_destroy(struct Scsi_Host *shost, u64 itn_id)
+{
+	return 0;
+}
+#endif
Signature · 1 line
1.5.2.4
#1 lore raw
Quoted 2 lines · FUJITA Tomonori

Hopefully, this works. Is there an easier way to remove tgt dependencies in scsi_transport_srp?

[...]

drivers/scsi/Kconfig source "drivers/scsi/libsas/Kconfig" · line 302

Quoted 2 lines
drivers/scsi/Kconfig +2 -0
+	depends on SCSI_SRP_ATTRS
+	depends on SCSI_TGT = y || SCSI_TGT = SCSI_SRP_ATTRS

I asked the same thing for the same problem in the libata in libsas config varible. Didn't get an answer though ... but my solution was the same as yours, if it helps.

James

#2 lore raw
Quoted 10 lines · On Wed, 01 Aug 2007 11:20:04 -0500 James Bottomley wrote:
Quoted 2 lines · FUJITA Tomonori

Hopefully, this works. Is there an easier way to remove tgt dependencies in scsi_transport_srp?

[...]

drivers/scsi/Kconfig source "drivers/scsi/libsas/Kconfig" · line 302

Quoted 2 lines
drivers/scsi/Kconfig +2 -0
+	depends on SCSI_SRP_ATTRS
+	depends on SCSI_TGT = y || SCSI_TGT = SCSI_SRP_ATTRS

I asked the same thing for the same problem in the libata in libsas config varible. Didn't get an answer though ... but my solution was the same as yours, if it helps.

and it's used in a few other places. It's common.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***