Skip to contentSkip to conversation

aec62xx: always tune PIO

PATCH In review Bartlomiej Zolnierkiewicz 2 participants 2 messages Aug 1, 2007 – Aug 6, 2007 libata

lore
Share & tools
lore

Bartlomiej Zolnierkiewicz

author
#0 lore raw

PATCH 3/3 aec62xx: always tune PIO

Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
---
 drivers/ide/pci/aec62xx.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/ide/pci/aec62xx.c +4 -4
Index: b/drivers/ide/pci/aec62xx.c
===================================================================
@@ -1,5 +1,5 @@
 /*
- * linux/drivers/ide/pci/aec62xx.c		Version 0.24	May 24, 2007
+ * linux/drivers/ide/pci/aec62xx.c		Version 0.25	Aug 1, 2007
  *
  * Copyright (C) 1999-2002	Andre Hedrick <[email protected]>
  * Copyright (C) 2007		MontaVista Software, Inc. <[email protected]>

@@ -207,10 +207,10 @@ static void __devinit init_hwif_aec62xx(
 	} else
 		hwif->set_dma_mode = &aec6260_set_mode;
 
-	if (!hwif->dma_base) {
-		hwif->drives[0].autotune = hwif->drives[1].autotune = 1;
+	hwif->drives[0].autotune = hwif->drives[1].autotune = 1;
+
+	if (hwif->dma_base == 0)
 		return;
-	}
 
 	hwif->ultra_mask = hwif->cds->udma_mask;
 	hwif->mwdma_mask = 0x07;
Acked-by on v1 3/3
#1 lore raw
Quoted 1 line · Bartlomiej Zolnierkiewicz
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
Acked-by Sergei Shtylyov <[email protected]>
Quoted 15 lines

Index: b/drivers/ide/pci/aec62xx.c
===================================================================

drivers/ide/pci/aec62xx.c +1 -1
@@ -1,5 +1,5 @@
 /*
- * linux/drivers/ide/pci/aec62xx.c		Version 0.24	May 24, 2007
+ * linux/drivers/ide/pci/aec62xx.c		Version 0.25	Aug 1, 2007
  *
  * Copyright (C) 1999-2002	Andre Hedrick <[email protected]>
  * Copyright (C) 2007		MontaVista Software, Inc. <[email protected]>

@@ -207,10 +207,10 @@ static void __devinit init_hwif_aec62xx(
 	} else
 		hwif->set_dma_mode = &aec6260_set_mode;

drivers/ide/pci/aec62xx.c static void __devinit init_hwif_aec62xx( · line 216

Quoted 10 lines
drivers/ide/pci/aec62xx.c +3 -3
-	if (!hwif->dma_base) {
-		hwif->drives[0].autotune = hwif->drives[1].autotune = 1;
+	hwif->drives[0].autotune = hwif->drives[1].autotune = 1;
+
+	if (hwif->dma_base == 0)
 		return;
-	}
 
 	hwif->ultra_mask = hwif->cds->udma_mask;
 	hwif->mwdma_mask = 0x07;

Ugh, I really need to complete the patch de-uglifying the speedproc()
methods in this driver...

MBR, Sergei