Skip to contentSkip to conversation

scripts/ver_linux : correct printing of binutils version

PATCH In review Jesper Juhl 2 participants 2 messages Aug 1, 2007 – Aug 28, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scripts/ver_linux : correct printing of binutils version

Hi,

Currently scripts/ver_linux prints "Binutils" or other random information for the version number in the "binutils" output line on some distributions. This patch corrects that.

When I initially submitted a patch to correct that, I was not aware that the output from "ld -v" could differ as much as it turned out it can, so my original fix turned out to not cover all bases. This patch works correctly with all the different "ld -v" output that people posted in replys to my first patch, so it should be a clear win over what we have currently.

Please apply.

---

 scripts/ver_linux |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
scripts/ver_linux +1 -3
index 8f8df93..27a5a21 100755
@@ -21,9 +21,7 @@ gcc --version 2>&1| grep gcc | awk \
 make --version 2>&1 | awk -F, '{print $1}' | awk \
       '/GNU Make/{print "Gnu make              ",$NF}'
 
-ld -v | awk -F\) '{print $1}' | awk \
-'/BFD/{print "binutils              ",$NF} \
-/^GNU/{print "binutils              ",$4}'
+echo "binutils               $(ld -v | egrep -o '[0-9]+\.[0-9\.]+')"
 
 echo -n "util-linux             "
 fdformat --version | awk '{print $NF}' | sed -e s/^util-linux-// -e s/\)$//
#1 lore raw
Quoted 6 lines · Jesper Juhl

Hi,

Currently scripts/ver_linux prints "Binutils" or other random information for the version number in the "binutils" output line on some distributions. This patch corrects that.

Quoted 8 lines

When I initially submitted a patch to correct that, I was not aware that the output from "ld -v" could differ as much as it turned out it can, so my original fix turned out to not cover all bases. This patch works correctly with all the different "ld -v" output that people posted in replys to my first patch, so it should be a clear win over what we have currently.

Please apply.

Done,

Sam