Skip to contentSkip to conversation

Syntax error in iptables.xslt

PATCH Applied Dan Nicholson 3 participants 3 messages Aug 2, 2007 – Aug 6, 2007 netfilter

lore
Share & tools
lore

Dan Nicholson

author
#0 lore raw

PATCH 1/1 Syntax error in iptables.xslt

Using the iptables.xslt stylesheet as shipped in iptables-1.3.8 is causing syntax errors when run through xsltproc.

$ echo | xsltproc iptables.xslt -
compilation error: file iptables.xslt line 118 element param
The value '$node' of the attribute 'name' is not a valid QName.
$ xsltproc --version
Using libxml 20627, libxslt 10120 and libexslt 813
xsltproc was compiled against libxml 20627, libxslt 10120 and libexslt 813
libxslt 10120 was compiled against libxml 20627
libexslt 813 was compiled against libxml 20627

The problem is that in <xsl:param name="$node"/>, "$node" is not a valid QName.

http://www.w3.org/TR/xslt#variables

Patch below converts to a valid name and the one expected in the rest of the stylesheet when using <xsl:with-param name="node"/>.

--
Dan

iptables.xslt +1 -1
Index: iptables.xslt
===================================================================
@@ -116,7 +116,7 @@
   </xsl:template>
   
   <xsl:template name="counters">
-    <xsl:param name="$node"/>
+    <xsl:param name="node"/>
     <xsl:text>[</xsl:text>
     <xsl:if test="string-length($node/@packet-count)"><xsl:value-of select="$node/@packet-count"/></xsl:if>
     <xsl:if test="string-length($node/@packet-count)=0">0</xsl:if>
#1 lore raw

* Dan Nicholson wrote, On 02/08/07 16:42:

Quoted 13 lines

Patch below converts to a valid name and the one expected in the rest of the stylesheet when using <xsl:with-param name="node"/>.

--
Dan

Index: iptables.xslt
===================================================================

iptables.xslt line 122

Quoted 8 lines
iptables.xslt +1 -1
@@ -116,7 +116,7 @@
   </xsl:template>
 
   <xsl:template name="counters">
-    <xsl:param name="$node"/>
+    <xsl:param name="node"/>
     <xsl:text>[</xsl:text>
     <xsl:if test="string-length($node/@packet-count)"><xsl:value-of select="$node/@packet-count"/></xsl:if>
     <xsl:if test="string-length($node/@packet-count)=0">0</xsl:if>

Thanks for spotting that. It would have had the effect of not restoring counters.

Patrick, please accept this patch.

Signed-off by: Sam Liddicott <[email protected]>

Sam

maintainer Applied
#2 lore raw
In reply to Dan Nicholson
Quoted 7 lines · Dan Nicholson

The problem is that in <xsl:param name="$node"/>, "$node" is not a valid QName.

http://www.w3.org/TR/xslt#variables

Patch below converts to a valid name and the one expected in the rest of the stylesheet when using <xsl:with-param name="node"/>.

Applied, thanks Dan.

Signature · 2 lines
"Será preciso viajar a través de los ojos de los idiotas" -- Poeta en
Nueva York -- Federico García Lorca.