cs5530: always tune PIO
PATCH 1/1 cs5530: always tune PIO
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
--- drivers/ide/pci/cs5530.c | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-)
drivers/ide/pci/cs5530.c +6 -13
@@ -1,5 +1,5 @@/* -* linux/drivers/ide/pci/cs5530.c Version 0.74 Jul 28 2007 +* linux/drivers/ide/pci/cs5530.c Version 0.75 Aug 2 2007 * * Copyright (C) 2000 Andre Hedrick <[email protected]> * Copyright (C) 2000 Mark Lord <[email protected]>
@@ -270,20 +270,13 @@ static void __devinit init_hwif_cs5530 ( basereg =CS5530_BASEREG (hwif); d0_timings =inl (basereg +0 ); -if (CS5530_BAD_PIO (d0_timings)) { -/* PIO timings not initialized? */ +if (CS5530_BAD_PIO (d0_timings))outl (cs5530_pio_timings[(d0_timings >>31 ) &1 ][0 ], basereg +0 ); -if (!hwif->drives[0 ].autotune) - hwif->drives[0 ].autotune =1 ; -/* needs autotuning later */ - } -if (CS5530_BAD_PIO (inl (basereg +8 ))) { -/* PIO timings not initialized? */ +if (CS5530_BAD_PIO (inl (basereg +8 )))outl (cs5530_pio_timings[(d0_timings >>31 ) &1 ][0 ], basereg +8 ); -if (!hwif->drives[1 ].autotune) - hwif->drives[1 ].autotune =1 ; -/* needs autotuning later */ - } + + hwif->drives[0 ].autotune =1 ; + hwif->drives[1 ].autotune =1 ;if (hwif->dma_base ==0 )return ;
Quoted 11 lines · On Fri, 3 Aug 2007 00:46:27 +0200 Bartlomiej Zolnierkiewicz…
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>--- drivers/ide/pci/cs5530.c | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-)Index:
b/drivers/ide/pci/cs5530.c
===================================================================
drivers/ide/pci/cs5530.c line 2
Quoted 3 lines
drivers/ide/pci/cs5530.c +1
-1@@ -1,5 +1,5 @@/* -* linux/drivers/ide/pci/cs5530.c Version 0.74 Jul 28 2007 +* linux/drivers/ide/pci/cs5530.c Version 0.75 Aug 2 2007
Looks good but if you've got BIOS set timings and you override them you might want to copy the Palmax handler from the libata one. Basically the Palmax has the CDROM in the docking station and the link between the two is not good enough for the highest mode the drive and cd can do but must be run PIO.