kill an obsolete sub-thread-ptrace stuff
PATCH 1/1 kill an obsolete sub-thread-ptrace stuff
There is a couple of subtle checks which were needed to handle ptracing from the same thread group. This was deprecated a long ago, imho this code just complicates the understanding.
And, the "->parent->signal->flags & SIGNAL_GROUP_EXIT" check in exit_notify() is not right. SIGNAL_GROUP_EXIT can mean exec(), not exit_group(). This means ptracer can lose a ptraced zombie on exec(). Minor problem, but still the bug.
kernel/exit.c renamed from kernel/exit.c~PT_TG +2 -6
@@ -802,7 +802,7 @@ static void exit_notify(struct task_stru__kill_pgrp_info (SIGCONT ,SEND_SIG_PRIV , pgrp); } -/* Let father know we died +/* Let father know we died * * Thread signals are configurable, but you aren't going to use * that to send signals to arbitary processes.
@@ -815,9 +815,7 @@ static void exit_notify(struct task_stru* If our self_exec id doesn't match our parent_exec_id then * we have changed execution domain as these two values started * the same after a fork. -* */ -if (tsk->exit_signal !=SIGCHLD && tsk->exit_signal !=-1 && ( tsk->parent_exec_id != t->self_exec_id || tsk->self_exec_id != tsk->parent_exec_id)
@@ -837,9 +835,7 @@ static void exit_notify(struct task_stru } state =EXIT_ZOMBIE ; -if (tsk->exit_signal ==-1 && - (likely (tsk->ptrace ==0 ) || -unlikely (tsk->parent->signal->flags &SIGNAL_GROUP_EXIT ))) +if (tsk->exit_signal ==-1 &&likely (!tsk->ptrace)) state =EXIT_DEAD ; tsk->exit_state = state;
kernel/signal.c renamed from kernel/signal.c~PT_TG +0 -4
@@ -1561,10 +1561,6 @@ static inline int may_ptrace_stop(void) (current->ptrace & PT_ATTACHED)))return 0 ; -if (unlikely (current->signal == current->parent->signal) && -unlikely (current->signal->flags &SIGNAL_GROUP_EXIT )) -return 0 ; -/* * Are we in the middle of do_coredump? * If so and our tracer is also part of the coredump stopping
Quoted 3 lines
There is a couple of subtle checks which were needed to handle ptracing from the same thread group. This was deprecated a long ago, imho this code just complicates the understanding.
Looks ok to me.
Quoted 3 lines
And, the "->parent->signal->flags &
SIGNAL_GROUP_EXIT" check inexit_notify()is not right.SIGNAL_GROUP_EXITcan meanexec(), notexit_group(). This means ptracer can lose a ptraced zombie onexec(). Minor problem, but still the bug.
This bug never happens because this check is only in the now-impossible ptrace-same-group case. The code can certainly go.
Thanks,
Roland
Quoted 6 lines · Roland McGrath
Quoted 4 lines
There is a couple of subtle checks which were needed to handle ptracing from the same thread group. This was deprecated a long ago, imho this code just complicates the understanding.
Looks ok to me.
Thanks!
Quoted 6 lines
Quoted 3 lines
And, the "->parent->signal->flags &
SIGNAL_GROUP_EXIT" check inexit_notify()is not right.SIGNAL_GROUP_EXITcan meanexec(), notexit_group(). This means ptracer can lose a ptraced zombie onexec(). Minor problem, but still the bug.This bug never happens because this check is only in the now-impossible ptrace-same-group case.
This means that changelog is wrong and should be changed.
However, I disagree. exit_notify() doesn't check the ptrace-same-group case. So, unless I missed something, we set EXIT_DEAD in any case, even if ptracer doesn't belong to our thread group.
No?
Oleg.
Quoted 3 lines
However, I disagree.
exit_notify()doesn't check the ptrace-same-group case. So, unless I missed something, we setEXIT_DEADin any case, even if ptracer doesn't belong to our thread group.
Oh, you're right. I was reading the other line you changed.
Thanks,
Roland