Skip to contentSkip to conversation

unexport asm/shmparam.h

PATCH In review Olaf Hering 2 participants 3 messages Jul 14, 2007 – Aug 4, 2007 Generic include/asm header files

lore
Share & tools
lore

Olaf Hering

author
#0 lore raw

PATCH 1/1 unexport asm/shmparam.h

SHMLBA cant possible be used in userspace, see sparc versions of that header.

Do not export asm/shmparam.h during make headers_install_all This removes another uservisible place of PAGE_SIZE

Signed-off-by Olaf Hering <[email protected]>
---
 include/asm-generic/Kbuild.asm |    1 -
 include/asm-powerpc/Kbuild     |    1 -
 include/asm-sparc64/shmparam.h |    2 --
 include/linux/shm.h            |    2 ++
 4 files changed, 2 insertions(+), 4 deletions(-)
include/asm-generic/Kbuild.asm +0 -1
@@ -30,6 +30,5 @@ unifdef-y += unistd.h
 unifdef-y += user.h
 
 # These probably shouldn't be exported
-unifdef-y += shmparam.h
 unifdef-y += elf.h
 unifdef-y += page.h
include/asm-powerpc/Kbuild +0 -1
@@ -15,7 +15,6 @@ header-y += termbits.h
 header-y += fcntl.h
 header-y += ipc.h
 header-y += poll.h
-header-y += shmparam.h
 header-y += sockios.h
 header-y += ucontext.h
 header-y += ioctl.h
include/asm-sparc64/shmparam.h +0 -2
@@ -1,7 +1,6 @@
 /* $Id: shmparam.h,v 1.5 2001/09/24 21:17:57 kanoj Exp $ */
 #ifndef _ASMSPARC64_SHMPARAM_H
 #define _ASMSPARC64_SHMPARAM_H
-#ifdef __KERNEL__
 
 #include <asm/spitfire.h>
 

@@ -9,5 +8,4 @@
 /* attach addr a multiple of this */
 #define	SHMLBA	((PAGE_SIZE > L1DCACHE_SIZE) ? PAGE_SIZE : L1DCACHE_SIZE)
 
-#endif /* __KERNEL__ */
 #endif /* _ASMSPARC64_SHMPARAM_H */
include/linux/shm.h +2 -0
@@ -16,7 +16,9 @@
 #define SHMALL (SHMMAX/PAGE_SIZE*(SHMMNI/16)) /* max shm system wide (pages) */
 #define SHMSEG SHMMNI			 /* max shared segs per process */
 
+#ifdef __KERNEL__
 #include <asm/shmparam.h>
+#endif
 
 /* Obsolete, used only for backwards compatibility and libc5 compiles */
 struct shmid_ds {
author
#1 lore raw
Quoted 1 line · Olaf Hering

SHMLBA cant possible be used in userspace, see sparc versions of that header.

Ping.
Anything wrong with this patch?

#2 lore raw
Quoted 5 lines · On Sat, 4 Aug 2007 12:07:43 +0200 Olaf Hering <[email protected]> wrote:
Quoted 1 line · Olaf Hering

SHMLBA cant possible be used in userspace, see sparc versions of that header.

Ping.

ping who?

Quoted 1 line

Anything wrong with this patch?

Not afaik. I queued it for 2.6.24.