Guard against a potential NULL pointer dereference in old_capi_manufacturer()
PATCH RESEND 1/1 Guard against a potential NULL pointer dereference in old_capi_manufacturer()
(first send: Monday 25 June 2007, resending due to no response) (resending again on August 8'th, 2007)
In drivers/isdn/capi/kcapi.c::old_capi_manufacturer(), if the call to get_capi_ctr_by_nr(ldef.contr); in line 823 returns NULL, then we'll be dereferencing a NULL pointer in the very next line.
(Found by Coverity checker as bug #402)
---
drivers/isdn/capi/kcapi.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/isdn/capi/kcapi.c +0 -0
@@ -821,6 +821,8 @@ static int old_capi_manufacturer(unsigned int cmd, void
__user *data)
return -EFAULT;
}
card = get_capi_ctr_by_nr(ldef.contr);
+ if (!card)
+ return -EINVAL;
card = capi_ctr_get(card);
if (!card)
return -ESRCH;
Quoted 4 lines · Jesper Juhl
(first send: Monday 25 June 2007, resending due to no response) (resending again on August 8'th, 2007)
Quoted 8 lines
In drivers/isdn/capi/kcapi.c::old_capi_manufacturer(), if the call to
get_capi_ctr_by_nr(ldef.contr); in line 823 returns NULL, then we'll be dereferencing a NULL pointer in the very next line.(Found by Coverity checker as bug #402)
Signed-off-by Jesper Juhl <[email protected]>
Quoted 25 lines
---
drivers/isdn/capi/kcapi.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)drivers/isdn/capi/kcapi.c +2
-0@@ -821,6 +821,8 @@ static int old_capi_manufacturer(unsigned int cmd, void __user *data)return -EFAULT ; } card =get_capi_ctr_by_nr (ldef.contr); +if (!card) +return -EINVAL ; card =capi_ctr_get (card);if (!card)drivers/isdn/capi/kcapi.c +0
-1return -ESRCH ; -To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Signature · 4 lines
Karsten Keil SuSE Labs ISDN and VOIP development SUSE LINUX Products GmbH, Maxfeldstr.5 90409 Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg)