Skip to contentSkip to conversation

usb: r8a66597-hcd: Clean up error path.

PATCH New Paul Mundt 1 participant 1 message Aug 7, 2007 USB

lore
Share & tools
lore

Paul Mundt

author
#0 lore raw

PATCH 1/1 usb: r8a66597-hcd: Clean up error path.

Currently when registration fails we're left with a stray reference to release_mem_region(), this leads to the following case:

    r8a66597_hcd r8a66597_hcd: irq 13, io base 0x18040000
    drivers/usb/host/r8a66597-hcd.c: register access fail.
    r8a66597_hcd r8a66597_hcd: startup error -6
    r8a66597_hcd r8a66597_hcd: USB bus 1 deregistered
    drivers/usb/host/r8a66597-hcd.c: Failed to add hcd
    Trying to free nonexistent resource <0000000018040000-0000000018040000>

This fixes it up.

--

 drivers/usb/host/r8a66597-hcd.c |    2 --
 1 file changed, 2 deletions(-)
drivers/usb/host/r8a66597-hcd.c +0 -2
index d60f198..40a1de4 100644
@@ -2208,8 +2208,6 @@ static int __init r8a66597_probe(struct platform_device *pdev)
 clean_up:
 	if (reg)
 		iounmap(reg);
-	if (res)
-		release_mem_region(res->start, 1);
 
 	return ret;
 }