Skip to contentSkip to conversation

make atomic_read() behave consistently on avr32

PATCH In review Chris Snook 1 participant 1 message Aug 9, 2007

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 3/24 make atomic_read() behave consistently on avr32

From: Chris Snook <[email protected]>

Purify volatile use for atomic_t on avr32.

include/asm-avr32/atomic.h +6 -2
@@ -16,10 +16,14 @@
 
 #include <asm/system.h>
 
-typedef struct { volatile int counter; } atomic_t;
+typedef struct { int counter; } atomic_t;
 #define ATOMIC_INIT(i)  { (i) }
 
-#define atomic_read(v)		((v)->counter)
+/*
+ * Casting to volatile here minimizes the need for barriers,
+ * without having to declare the type itself as volatile.
+ */
+#define atomic_read(v)		(*(volatile int *)&(v)->counter)
 #define atomic_set(v, i)	(((v)->counter) = i)
 
 /*