Skip to contentSkip to conversation

make atomic_read() behave consistently on cris

PATCH In review Chris Snook 1 participant 1 message Aug 9, 2007

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 5/24 make atomic_read() behave consistently on cris

From: Chris Snook <[email protected]>

Purify volatile use for atomic_t on cris.

include/asm-cris/atomic.h +6 -2
@@ -11,11 +11,15 @@
  * resource counting etc..
  */
 
-typedef struct { volatile int counter; } atomic_t;
+typedef struct { int counter; } atomic_t;
 
 #define ATOMIC_INIT(i)  { (i) }
 
-#define atomic_read(v) ((v)->counter)
+/*
+ * Casting to volatile here minimizes the need for barriers,
+ * without having to declare the type itself as volatile.
+ */
+#define atomic_read(v) (*(volatile int *)&(v)->counter)
 #define atomic_set(v,i) (((v)->counter) = (i))
 
 /* These should be written in asm but we do it in C for now. */