Skip to contentSkip to conversation

make atomic_read() behave consistently on sparc64

PATCH In review Chris Snook 1 participant 1 message Aug 9, 2007

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 19/24 make atomic_read() behave consistently on sparc64

From: Chris Snook <[email protected]>

Purify volatile use for atomic[64]_t on sparc64.

include/asm-sparc64/atomic.h +8 -4
@@ -11,14 +11,18 @@
 #include <linux/types.h>
 #include <asm/system.h>
 
-typedef struct { volatile int counter; } atomic_t;
-typedef struct { volatile __s64 counter; } atomic64_t;
+typedef struct { int counter; } atomic_t;
+typedef struct { __s64 counter; } atomic64_t;
 
 #define ATOMIC_INIT(i)		{ (i) }
 #define ATOMIC64_INIT(i)	{ (i) }
 
-#define atomic_read(v)		((v)->counter)
-#define atomic64_read(v)	((v)->counter)
+/*
+ * Casting to volatile here minimizes the need for barriers,
+ * without having to declare the type itself as volatile.
+ */
+#define atomic_read(v)		(*(volatile int *)&(v)->counter)
+#define atomic64_read(v)	(*(volatile __s64 *)&(v)->counter)
 
 #define atomic_set(v, i)	(((v)->counter) = i)
 #define atomic64_set(v, i)	(((v)->counter) = i)