include linux/types.h in if_fddi.h

include/linux/if_fddi.h is an exported header.
It uses __be16. Include linux/types.h to get this prototype.

---
 include/linux/if_fddi.h |    2 ++
 1 file changed, 2 insertions(+)

@@ -24,6 +24,8 @@
 #ifndef _LINUX_IF_FDDI_H
 #define _LINUX_IF_FDDI_H
 
+#include <linux/types.h>
+
 /*
  *  Define max and min legal sizes.  The frame sizes do not include
  *  4 byte FCS/CRC (frame check sequence).

Please note that for userland it does not matter. With glibc you should
include <netinet/if_fddi.h> which does the necessary bits before including <linux/if_fddi.h>. Any other C library should likely take a similar approach.

It still seems right for Linux itself though.

Maciej

Ok, I will update the failing package.

Please drop the patch.

glibc includes asm/types.h, not linux/types.h. So changing the package to netinet/if_fddi.h does not fix anything.

Please dont drop it.
Or should all glibc includes be changed from asm/types.h to linux/types.h?

Well, it looks like we have changed the rules at one point, so it is up
to us to fix the things up. Even if the glibc maintainers are persuaded to accept a change (which I might try to do), older versions are already out there and people may still want to use it for one reason or another (including myself -- I am not ready to move on with glibc and will have to stick to version 2.4 for several months yet).

Maciej

It doesn't make any sense to habe all libc's figure out inter-header dependencies.

For each userspace exported header file an #include <linux/foo.h> should always compile, and if it fails due to missing #include's in the header that's a bug that should be fixed.

cu
Adrian

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed