Skip to contentSkip to conversation

Minor fix to Documentation/powerpc/00-INDEX

PATCH In review Rob Landley 3 participants 5 messages Aug 10, 2007 – Aug 12, 2007 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Minor fix to Documentation/powerpc/00-INDEX

I have a python script to convert 00-INDEX files into index.html files, and a second script to show 404 errors in the result as well as files/directories
nothing links to. (It's not very useful yet, but in case you're wondering
http://kernel.org/doc/docdiridx.py and http://kernel.org/doc/doclinkcheck.py
.)

Anyway, my simple index.html generator breaks on the Documentation/powerpc directory because one of the description lines is two lines long. This patch joins those two lines together into one line. This is the only instance (so far) of this problem.

---

In case you're wondering, here are the current the 404 errors in the various 00-INDEX files. Fixing all this is on my todo list:

Documentation/ecryptfs.txt
Documentation/time_interpolators.txt
Documentation/arm/SA1100
Documentation/arm/XScale
Documentation/arm/empeg
Documentation/arm/nwfpe
Documentation/isdn/README.eicon
Documentation/fb/clgenfb.txt
Documentation/networking/ethertap.txt
Documentation/filesystems/reiser4.txt
Documentation/scsi/AM53C974.txt
Documentation/scsi/ChangeLog

The "files and directories not linked to" list is 679 lines long.

Documentation/powerpc/00-INDEX +1 -2
diff -r /dev/null Documentation/powerpc/00-INDEX
@@ -6,8 +6,7 @@ 00-INDEX
 00-INDEX
 	- this file
 cpu_features.txt
-	- info on how we support a variety of CPUs with minimal compile-time
-	options.
+	- info on how we support a variety of CPUs with minimal compile-time options.
 eeh-pci-error-recovery.txt
 	- info on PCI Bus EEH Error Recovery
 hvcs.txt
Signature · 2 lines
"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.
#1 lore raw
Quoted 8 lines · On Thu, 9 Aug 2007 23:42:35 -0500 Rob Landley wrote:

I have a python script to convert 00-INDEX files into index.html files, and a second script to show 404 errors in the result as well as files/directories
nothing links to. (It's not very useful yet, but in case you're wondering
http://kernel.org/doc/docdiridx.py and http://kernel.org/doc/doclinkcheck.py
.)

Quoted 4 lines

Anyway, my simple index.html generator breaks on the Documentation/powerpc directory because one of the description lines is two lines long. This patch joins those two lines together into one line. This is the only instance (so far) of this problem.

If Paul wants to merge this, then OK, but I'm not aware of any rule that the file descriptions inside INDEX files must be only one line long... is that documented somewhere? (if so, where?)

Maybe the script should allow for this?

Quoted 24 lines

---

In case you're wondering, here are the current the 404 errors in the various 00-INDEX files. Fixing all this is on my todo list:

Documentation/ecryptfs.txt
Documentation/time_interpolators.txt
Documentation/arm/SA1100
Documentation/arm/XScale
Documentation/arm/empeg
Documentation/arm/nwfpe
Documentation/isdn/README.eicon
Documentation/fb/clgenfb.txt
Documentation/networking/ethertap.txt
Documentation/filesystems/reiser4.txt
Documentation/scsi/AM53C974.txt
Documentation/scsi/ChangeLog

The "files and directories not linked to" list is 679 lines long.

diff -r /dev/null Documentation/powerpc/00-INDEX

Documentation/powerpc/00-INDEX 00-INDEX · line 12

Quoted 9 lines
Documentation/powerpc/00-INDEX +1 -2
@@ -6,8 +6,7 @@ 00-INDEX
 00-INDEX
 	- this file
 cpu_features.txt
-	- info on how we support a variety of CPUs with minimal compile-time
-	options.
+	- info on how we support a variety of CPUs with minimal compile-time options.
 eeh-pci-error-recovery.txt
 	- info on PCI Bus EEH Error Recovery
 hvcs.txt

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

#2 lore raw
Quoted 9 lines · Randy Dunlap
Quoted 8 lines · On Thu, 9 Aug 2007 23:42:35 -0500 Rob Landley wrote:

I have a python script to convert 00-INDEX files into index.html files, and a second script to show 404 errors in the result as well as
files/directories nothing links to. (It's not very useful yet, but in
case you're wondering http://kernel.org/doc/docdiridx.py and
http://kernel.org/doc/doclinkcheck.py .)

Quoted 8 lines
Quoted 4 lines

Anyway, my simple index.html generator breaks on the Documentation/powerpc directory because one of the description lines is two lines long. This patch joins those two lines together into one line.
This is the only instance (so far) of this problem.

If Paul wants to merge this, then OK, but I'm not aware of any rule that the file descriptions inside INDEX files must be only one line long... is that documented somewhere? (if so, where?)

Documentation/00-INDEX line 5:

Quoted 1 line

Please try and keep the descriptions small enough to fit on one line.

There was only one instance of it not being the case. I can use indentation level instead (which is what Kconfig uses to identify help text, so I'm not leaking pythonisms into the kernel that aren't already there), but the one line thing seemed to be an existing standard.

I'm also relying on the first file in the list being documentation for 00-INDEX itself. (If it breaks, I'll either try to derive a new heuristic and change the script, or submit a patch to change the index. That one would be a more difficult heuristic to replace, though.)

Quoted 1 line

Maybe the script should allow for this?

*shrug* I can go either way on that, but people get all funny about whitespace being significant and the one line thing wasn't my idea. :)

Rob

Signature · 2 lines
"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.
#3 lore raw
Quoted 19 lines · Rob Landley
Quoted 9 lines · Randy Dunlap
Quoted 8 lines · On Thu, 9 Aug 2007 23:42:35 -0500 Rob Landley wrote:

I have a python script to convert 00-INDEX files into index.html files, and a second script to show 404 errors in the result as well as
files/directories nothing links to. (It's not very useful yet, but in
case you're wondering http://kernel.org/doc/docdiridx.py and
http://kernel.org/doc/doclinkcheck.py .)

Quoted 8 lines
Quoted 4 lines

Anyway, my simple index.html generator breaks on the Documentation/powerpc directory because one of the description lines is two lines long. This patch joins those two lines together into one line.
This is the only instance (so far) of this problem.

If Paul wants to merge this, then OK, but I'm not aware of any rule that the file descriptions inside INDEX files must be only one line long... is that documented somewhere? (if so, where?)

Quoted 9 lines

Documentation/00-INDEX line 5:

Quoted 1 line

Please try and keep the descriptions small enough to fit on one line.

There was only one instance of it not being the case. I can use indentation level instead (which is what Kconfig uses to identify help text, so I'm not leaking pythonisms into the kernel that aren't already there), but the one line thing seemed to be an existing standard.

The two times that I've done some big updates to Documentation/00-INDEX I've also stuck to one line for each description since that was the only form I'd ever seen - I didn't know if it was a rule or not, but it seemed pretty sensible for an index. It's also the form I've stuck to for the new files I send patches for recently.

So for whatever my oppinion is worth; I think we may as well make it a rule for the 00-INDEX files.

Signature · 3 lines
Jesper Juhl <[email protected]>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
#4 lore raw
Quoted 16 lines · On Sun, 12 Aug 2007 22:16:43 +0200 Jesper Juhl wrote:
Quoted 15 lines · Rob Landley
Quoted 14 lines · Randy Dunlap
Quoted 12 lines · On Thu, 9 Aug 2007 23:42:35 -0500 Rob Landley wrote:

I have a python script to convert 00-INDEX files into index.html files, and a second script to show 404 errors in the result as well as
files/directories nothing links to. (It's not very useful yet, but in
case you're wondering http://kernel.org/doc/docdiridx.py and
http://kernel.org/doc/doclinkcheck.py .)

Anyway, my simple index.html generator breaks on the Documentation/powerpc directory because one of the description lines is two lines long. This patch joins those two lines together into one line.
This is the only instance (so far) of this problem.

Quoted 7 lines
Quoted 7 lines
Quoted 3 lines

If Paul wants to merge this, then OK, but I'm not aware of any rule that the file descriptions inside INDEX files must be only one line long... is that documented somewhere? (if so, where?)

Documentation/00-INDEX line 5:

Quoted 1 line

Please try and keep the descriptions small enough to fit on one line.

OK :)

Quoted 5 lines
Quoted 5 lines

There was only one instance of it not being the case. I can use indentation level instead (which is what Kconfig uses to identify help text, so I'm not leaking pythonisms into the kernel that aren't already there), but the one line thing seemed to be an existing standard.

Quoted 8 lines

The two times that I've done some big updates to Documentation/00-INDEX I've also stuck to one line for each description since that was the only form I'd ever seen - I didn't know if it was a rule or not, but it seemed pretty sensible for an index. It's also the form I've stuck to for the new files I send patches for recently.

So for whatever my oppinion is worth; I think we may as well make it a rule for the 00-INDEX files.

I think that it's a reasonable rule.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***