phy layer: fix genphy_setup_forced (don't reset)

PATCH Applied Domen Puncer 3 participants 3 messages Aug 17, 2007 – Aug 25, 2007

Subsystems (3)

Networking Network drivers Ethernet PHY

lore

Share & tools

lore

Domen Puncer

author

2007-08-17 06:54 UTC #0 lore raw

PATCH 1/1 phy layer: fix genphy_setup_forced (don't reset)

Writing BMCR_RESET bit will reset MII_BMCR to default values. This is clearly not what we want.

Signed-off-by Domen Puncer <[email protected]>

---
 drivers/net/phy/phy_device.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/net/phy/phy_device.c +1 -1

Index: work-powerpc.git/drivers/net/phy/phy_device.c
===================================================================
@@ -364,7 +364,7 @@ EXPORT_SYMBOL(genphy_config_advert);
  */
 int genphy_setup_forced(struct phy_device *phydev)
 {
-	int ctl = BMCR_RESET;
+	int ctl = 0;
 
 	phydev->pause = phydev->asym_pause = 0;

Andy Fleming

Acked-by on v1 1/1

2007-08-20 19:43 UTC #1 lore raw

Quoted 5 lines · Domen Puncer

Writing BMCR_RESET bit will reset MII_BMCR to default values. This is clearly not what we want.
Signed-off-by Domen Puncer <[email protected]>

Acked-by Andy Fleming <[email protected]>

I could have sworn there was a patch that did this, already, but it must have lost steam somewhere.

Andy

Jeff Garzik

Applied

2007-08-25 04:40 UTC #2 lore raw

In reply to Domen Puncer

Quoted 15 lines · Domen Puncer

Writing BMCR_RESET bit will reset MII_BMCR to default values. This is clearly not what we want.
Signed-off-by Domen Puncer <[email protected]>
---
 drivers/net/phy/phy_device.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Index: work-powerpc.git/drivers/net/phy/phy_device.c
===================================================================

drivers/net/phy/phy_device.c EXPORT_SYMBOL(genphy_config_advert); · line 369

Quoted 7 lines

drivers/net/phy/phy_device.c +1 -1

@@ -364,7 +364,7 @@ EXPORT_SYMBOL(genphy_config_advert);
  */
 int genphy_setup_forced(struct phy_device *phydev)
 {
-	int ctl = BMCR_RESET;
+	int ctl = 0;
 
 	phydev->pause = phydev->asym_pause = 0;

applied