DMA engine kconfig improvements (rev2)
PATCH 1/1 DMA engine kconfig improvements (rev2)
From: Adrian Bunk <[email protected]>
This patch contains the following changes to the DMA engine menus:
- switch to menuconfig
- INTEL_IOATDMA must depend on X86
- INTEL_IOATDMA must select DCA
- device drivers shouldn't "default m"
- DCA shouldn't be a user visible option
- make it clear in the INTEL_IOATDMA help text that this driver is for rare hardware the user most likely doesn't has
- let DMA_ENGINE be select'ed by the DMA devices, making it less likely for a user to accidentally enable NET_DMA
---
drivers/dca/Kconfig | 7 ++---- drivers/dma/Kconfig | 60 ++++++++++++++++++++++++++++++--------------------- 2 files changed, 37 insertions(+), 30 deletions(-)
drivers/dca/Kconfig +2 -5
@@ -3,9 +3,6 @@ # config DCA - tristate "DCA support for clients and providers" - ---help--- - This is a server to help modules that want to use Direct Cache - Access to find DCA providers that will supply correct CPU tags. - default m + tristate +
drivers/dma/Kconfig +35 -25
77 lines not on this page · raw message
Quoted 7 lines · Shannon Nelson
From: Adrian Bunk <[email protected]>
This patch contains the following changes to the DMA engine menus:
...
- make it clear in theINTEL_IOATDMAhelp text that this driver is for rare hardware the user most likely doesn't has
...
drivers/dma/Kconfig line 23
Quoted 9 lines
drivers/dma/Kconfig +8
-0+config INTEL_IOATDMA + tristate "Intel I/OAT DMA support" + depends on PCI && X86 + select DMA_ENGINE + select DCA + help + Enable support for the Intel(R) I/OAT DMA engine present + in recent chipsets.
It seems the string "Xeon" somehow got lost, or is it now also available with other hardware?
"in recent Intel Xeon chipsets"?
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedQuoted 29 lines
From: Adrian Bunk [mailto:[email protected]]
Sent: Thursday, August 16, 2007 5:48 PM
To: Nelson, Shannon
Cc: [email protected]; [email protected]; Williams, Dan J; [email protected]
Subject: Re: [-mm PATCH] DMA engine kconfig improvements (rev2)Quoted 5 lines · Shannon Nelson
From: Adrian Bunk <[email protected]>
This patch contains the following changes to the DMA engine menus:
...
- make it clear in theINTEL_IOATDMAhelp text that thisdriver is for
drivers/dma/Kconfig line 23
Quoted 11 lines
rare hardware the user most likely doesn't has
...drivers/dma/Kconfig +8
-0+config INTEL_IOATDMA + tristate "Intel I/OAT DMA support" + depends on PCI && X86 + select DMA_ENGINE + select DCA + help + Enable support for the Intel(R) I/OAT DMA engine present + in recent chipsets.It seems the string "Xeon" somehow got lost, or is it now also available with other hardware?
Quoted 4 lines
"in recent Intel Xeon chipsets"?
cu
Adrian
Good catch - however, it is probably best not to limit these things.
sln
--
======================================================================
Mr. Shannon Nelson LAN Access Division, Intel Corp.
[email protected] I don't speak for Intel
(503) 712-7659 Parents can't afford to be squeamish.
Quoted 29 lines · Shannon
Quoted 29 lines
From: Adrian Bunk [mailto:[email protected]]
Sent: Thursday, August 16, 2007 5:48 PM
To: Nelson, Shannon
Cc: [email protected]; [email protected]; Williams, Dan J; [email protected]
Subject: Re: [-mm PATCH] DMA engine kconfig improvements (rev2)Quoted 5 lines · Shannon Nelson
From: Adrian Bunk <[email protected]>
This patch contains the following changes to the DMA engine menus:
...
- make it clear in theINTEL_IOATDMAhelp text that thisdriver is for
drivers/dma/Kconfig line 23
Quoted 11 lines
rare hardware the user most likely doesn't has
...drivers/dma/Kconfig +8
-0+config INTEL_IOATDMA + tristate "Intel I/OAT DMA support" + depends on PCI && X86 + select DMA_ENGINE + select DCA + help + Enable support for the Intel(R) I/OAT DMA engine present + in recent chipsets.It seems the string "Xeon" somehow got lost, or is it now also available with other hardware?
Quoted 6 lines
Quoted 4 lines
"in recent Intel Xeon chipsets"?
cu
AdrianGood catch - however, it is probably best not to limit these things.
Since the effects of CONFIG_NET_DMA are considered big enough to warrant all these #ifdef's in the net code it should be made clear for the user that this is only for hardware he most likely doesn't has.
And it's not about any kind of kconfig dependency, it's simply about the help text.
Quoted 1 line
sln
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed