__group_complete_signal: eliminate unneeded wakeup of ->group_exit_task
PATCH 1/1 __group_complete_signal: eliminate unneeded wakeup of ->group_exit_task
Cleanup. __group_complete_signal() wakes up ->group_exit_task twice. The second wakeup's state includes TASK_UNINTERRUPTIBLE, which is not very appropriate.
Change the code to pass the "correct" argument to signal_wake_up() and kill now unneeded wake_up_process().
Signed-off-by Oleg Nesterov <[email protected]>
kernel/signal.c renamed from kernel/signal.c~2_GCS_NOWAKEUP +4 -7
@@ -911,8 +911,7 @@ __group_complete_signal(int sig, struct do { sigaddset(&t->pending.signal, SIGKILL); signal_wake_up(t, 1); - t =next_thread (t); - }while (t != p); + } while_each_thread(p, t); return; }
@@ -930,13 +929,11 @@ __group_complete_signal(int sig, structrm_from_queue (SIG_KERNEL_STOP_MASK , &p->signal->shared_pending); p->signal->group_stop_count =0 ; p->signal->group_exit_task = t; - t = p; + p = t; do { p->signal->group_stop_count++; -signal_wake_up (t,0 ); - t =next_thread (t); - }while (t != p); -wake_up_process (p->signal->group_exit_task); + signal_wake_up(t, t == p); + } while_each_thread(p, t); return; }