Skip to contentSkip to conversation

IRDA: Avoid a label defined but not used warning in irda_init()

PATCH Applied Jesper Juhl 2 participants 2 messages Aug 17, 2007 – Aug 21, 2007 Networking

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 IRDA: Avoid a label defined but not used warning in irda_init()

Hi,

Easily avoidable compiler warnings bug me.

Building irmod without CONFIG_SYSCTL currently results in :
net/irda/irmod.c:132: warning: label 'out_err_2' defined but not used

But that can easily be avoided by simply moving the label inside the existing "#ifdef CONFIG_SYSCTL" one line above it.

This patch moves the label and buys us one less warning with no ill effects.

---

 net/irda/irmod.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
net/irda/irmod.c +1 -1
index 1900937..8ba703d 100644
@@ -128,8 +128,8 @@ static int __init irda_init(void)
  out_err_3:
 #ifdef CONFIG_SYSCTL
 	irda_sysctl_unregister();
-#endif
  out_err_2:
+#endif
 #ifdef CONFIG_PROC_FS
 	irda_proc_unregister();
 #endif
maintainer Applied
#1 lore raw

From: Jesper Juhl <[email protected]>
Date: Fri, 17 Aug 2007 23:22:33 +0200

Quoted 8 lines

Hi,

Easily avoidable compiler warnings bug me.

Building irmod without CONFIG_SYSCTL currently results in :
net/irda/irmod.c:132: warning: label 'out_err_2' defined but not used

Quoted 8 lines

But that can easily be avoided by simply moving the label inside the existing "#ifdef CONFIG_SYSCTL" one line above it.

This patch moves the label and buys us one less warning with no ill effects.

Applied, thanks Jesper.