Skip to contentSkip to conversation

Fix sed fail when building qtopia

PATCH New Thiago A. Corrêa 2 participants 4 messages Aug 20, 2007 – Aug 21, 2007 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix sed fail when building qtopia

Hi there,

This patch should fix the error:
sed: -e expression #1, char 21: unknown option to `s'

I am sure there is a better way to do this, but I'm not comfortable
with shell scripts enough, so, if someone has a better solution, by all means :)

Chears,
Thiago A. Correa
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-qtopia.patch
Type: application/octet-stream
Size: 1615 bytes
Desc: not available
Url : http://busybox.net/lists/buildroot/attachments/20070820/52757f95/attachment.obj

#1 lore raw

PATCH 1/1 Fix sed fail when building qtopia

Quoted 8 lines · Thiago A. Corr?a

Hi there,

This patch should fix the error:
sed: -e expression #1, char 21: unknown option to `s'

I am sure there is a better way to do this, but I'm not comfortable
with shell scripts enough, so, if someone has a better solution, by all means :)

ergh, that's rather ugly.
Please try to use this instead and let me know if that works for you:
$(SED) 's,-O2,$(TARGET_CFLAGS),' \
$(QTOPIA4_TARGET_DIR)/mkspecs/qws/linux-$(BR2_PACKAGE_QTOPIA4_EMB_PLATFORM)-g++/qmake.conf

(i.e. use ',' instead if '/'.

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw

PATCH 1/1 Fix sed fail when building qtopia

Ops, didn't send the msg to the list, sorry. Perhaps one could consider changing the default reply to the list rather than to the poster.

Oh, btw, this patch fixes bug 0001457, please apply and close the issue on the bugtracker. Thanks :)

---------- Forwarded message ----------
From: Thiago A. Corr?a <[email protected]>
Date: Aug 20, 2007 7:36 PM
Subject: Re: [Buildroot] [PATCH] Fix sed fail when building qtopia
To: Bernhard Fischer <[email protected]>

Yes, much better indeed. And it works fine now. At least that part so far :)

After that, I get a link error building moc, haven't figured that one yet.

I have attached the patch updated, thanks.

Cheers,
Thiago A. Correa

Quoted 10 lines · Bernhard Fischer
Quoted 8 lines · Thiago A. Corr?a

Hi there,

This patch should fix the error:
sed: -e expression #1, char 21: unknown option to `s'

I am sure there is a better way to do this, but I'm not comfortable
with shell scripts enough, so, if someone has a better solution, by all means :)

Quoted 7 lines

ergh, that's rather ugly.
Please try to use this instead and let me know if that works for you:
$(SED) 's,-O2,$(TARGET_CFLAGS),' \
$(QTOPIA4_TARGET_DIR)/mkspecs/qws/linux-$(BR2_PACKAGE_QTOPIA4_EMB_PLATFORM)-g++/qmake.conf

(i.e. use ',' instead if '/'.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-qtopia.patch
Type: application/octet-stream
Size: 1425 bytes
Desc: not available
Url : http://busybox.net/lists/buildroot/attachments/20070821/456632e0/attachment.obj

#4 lore raw

PATCH 1/1 Fix sed fail when building qtopia

In reply to a message not in the archive
Quoted 5 lines · Thiago A. Corr?a

Yes, much better indeed. And it works fine now. At least that part so far :)

After that, I get a link error building moc, haven't figured that one yet.

I have attached the patch updated, thanks.

Applied. Thanks!