Skip to contentSkip to conversation

alsa: replace calls to sys_* with filp_open and vfs_read

PATCH In review Eugene Teo 2 participants 2 messages Aug 21, 2007

Subsystems (2)
VFS Sound
lore
Share & tools
lore

Eugene Teo

author
#0 lore raw

PATCH 1/1 alsa: replace calls to sys_* with filp_open and vfs_read

This patch replaces calls to sys_* with filp_open and vfs_read. And since this is the last driver in the kernel that uses sys_{read,close}, it kills the exports as well. sys_open is left exported for sparc64 only.

Cc Takashi Iwai <[email protected]>
Signed-off-by Eugene Teo <[email protected]>
Signed-off-by Arjan van de Ven <[email protected]>
---
 fs/open.c                             |    4 +-
 fs/read_write.c                       |    1 -
 sound/isa/wavefront/wavefront_synth.c |   47 +++++++++++++++-----------------
 3 files changed, 24 insertions(+), 28 deletions(-)
fs/open.c +2 -2
index 1d9e5e9..dc121ce 100644
@@ -1056,7 +1056,9 @@ asmlinkage long sys_open(const char __user *filename, int flags, int mode)
 	prevent_tail_call(ret);
 	return ret;
 }
+#ifdef CONFIG_SPARC64
 EXPORT_SYMBOL_GPL(sys_open);
+#endif
 
 asmlinkage long sys_openat(int dfd, const char __user *filename, int flags,
 			   int mode)

@@ -1148,8 +1150,6 @@ out_unlock:
 	return -EBADF;
 }
 
-EXPORT_SYMBOL(sys_close);
-
 /*
  * This routine simulates a hangup on the tty, to arrange that users
  * are given clean terminals at login time.
fs/read_write.c +0 -1
index 507ddff..d913d1e 100644
@@ -370,7 +370,6 @@ asmlinkage ssize_t sys_read(unsigned int fd, char __user * buf, size_t count)
 
 	return ret;
 }
-EXPORT_SYMBOL_GPL(sys_read);
 
 asmlinkage ssize_t sys_write(unsigned int fd, const char __user * buf, size_t count)
 {
sound/isa/wavefront/wavefront_synth.c +22 -25

88 lines not on this page · raw message

#1 lore raw

At Tue, 21 Aug 2007 12:38:02 +0800,

Quoted 8 lines · Eugene Teo

This patch replaces calls to sys_* with filp_open and vfs_read. And since this is the last driver in the kernel that uses sys_{read,close}, it kills the exports as well. sys_open is left exported for sparc64 only.

Cc Takashi Iwai <[email protected]>
Signed-off-by Eugene Teo <[email protected]>
Signed-off-by Arjan van de Ven <[email protected]>

Oh, then I forgot this completely. If this is the last dinosaur, we should rewrite it to use request_firmware(), and kill sys_* exports then.

I'll prepare a patch to rewrite wavefront_synth.c soon.

Thanks.

Takashi