UML doesn't build in 2.6.23-rc3.

uml-devel Rob Landley 2 participants 7 messages Aug 22, 2007 – Sep 4, 2007

Subsystems (3)

Generic include/asm header files User-mode Linux (UML) MMU gather and TLB invalidation

lore

Share & tools

lore

Rob Landley

author

2007-08-22 02:48 UTC #0 lore raw

I fixed it for me with the following patch, just in case anybody else had this problem:

arch/um/kernel/smp.c +1 -0

@@ -5,6 +5,7 @@
 
 #include "linux/percpu.h"
 #include "asm/pgalloc.h"
+#include "linux/pagemap.h"
 #include "asm/tlb.h"
 
 /* For some reason, mmu_gathers are referenced when CONFIG_SMP is off. */

Signature · 12 lines

"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Jeff Dike

2007-08-22 17:25 UTC #1 lore raw

Quoted 2 lines · Rob Landley

I fixed it for me with the following patch, just in case anybody else had this problem:

What were the errors?

Jeff

Signature · 11 lines

Work email - jdike at linux dot intel dot com

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Rob Landley

author

2007-08-22 20:26 UTC #2 lore raw

Quoted 7 lines · Jeff Dike

Quoted 2 lines · Rob Landley
I fixed it for me with the following patch, just in case anybody else had this problem:
What were the errors?
Jeff

CC arch/um/os-Linux/file.o
In file included from include/asm/arch/tlb.h:18,
from include/asm/tlb.h:4,
from arch/um/kernel/smp.c:8:
include/asm-generic/tlb.h: In function ‘tlb_flush_mmu’:
include/asm-generic/tlb.h:76: error: implicit declaration of function ‘release_pages’
include/asm-generic/tlb.h: In function ‘tlb_remove_page’:
include/asm-generic/tlb.h:105: error: implicit declaration of function ‘page_cache_release’
make[1]: *** [arch/um/kernel/smp.o] Error 1
make: *** [arch/um/kernel] Error 2
make: *** Waiting for unfinished jobs....

Rob

Signature · 12 lines

"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Jeff Dike

2007-08-22 21:31 UTC #3 lore raw

Quoted 6 lines · Rob Landley

include/asm-generic/tlb.h: In function ‘tlb_flush_mmu’:
include/asm-generic/tlb.h:76: error: implicit declaration of function ‘release_pages’
include/asm-generic/tlb.h: In function ‘tlb_remove_page’:
include/asm-generic/tlb.h:105: error: implicit declaration of function ‘page_cache_release’

Shouldn't the new include go in asm-generic/tlb.h instead?

include/asm-generic/tlb.h +1 -0

Index: linux-2.6.22/include/asm-generic/tlb.h
===================================================================
@@ -13,6 +13,7 @@
 #ifndef _ASM_GENERIC__TLB_H
 #define _ASM_GENERIC__TLB_H
 
+#include <linux/pagemap.h>
 #include <linux/swap.h>
 #include <asm/pgalloc.h>
 #include <asm/tlbflush.h>

This doesn't cause any obvious problems, but then I wasn't seeing the build failure in the first place.

Jeff

Signature · 11 lines

Work email - jdike at linux dot intel dot com

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Rob Landley

author

2007-08-23 01:47 UTC #4 lore raw

Quoted 9 lines · Jeff Dike

Quoted 6 lines · Rob Landley
include/asm-generic/tlb.h: In function ‘tlb_flush_mmu’:
include/asm-generic/tlb.h:76: error: implicit declaration of function ‘release_pages’
include/asm-generic/tlb.h: In function ‘tlb_remove_page’:
include/asm-generic/tlb.h:105: error: implicit declaration of function ‘page_cache_release’
Shouldn't the new include go in asm-generic/tlb.h instead?

I didn't say it was the right fix, just that it got it to work for me. :)

Quoted 2 lines

This doesn't cause any obvious problems, but then I wasn't seeing the build failure in the first place.

cat > mini.conf << EOF
CONFIG_MODE_SKAS=y
CONFIG_BINFMT_ELF=y
CONFIG_HOSTFS=y
CONFIG_SYSCTL=y
CONFIG_STDERR_CONSOLE=y
CONFIG_UNIX98_PTYS=y
CONFIG_BLK_DEV_LOOP=y
CONFIG_LBD=y
CONFIG_EXT2_FS=y
CONFIG_PROC_FS=y
EOF
make ARCH=um allnoconfig KCONFIG_ALLCONFIG=mini.conf make ARCH=um

Does that reproduce it for you?

Quoted 1 line

Jeff

Rob

Signature · 12 lines

"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Jeff Dike

2007-08-23 03:44 UTC #5 lore raw

Quoted 1 line · Rob Landley

Does that reproduce it for you?

Yup, but it's somewhat non-obvious why. Anyway, it seems clear that asm-generic/tlb.h is missing an include.

Jeff

Signature · 11 lines

Work email - jdike at linux dot intel dot com

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Rob Landley

author

2007-09-04 12:38 UTC #6 lore raw

Quoted 7 lines · Jeff Dike

Quoted 1 line · Rob Landley
Does that reproduce it for you?
Yup, but it's somewhat non-obvious why. Anyway, it seems clear that asm-generic/tlb.h is missing an include.
Jeff

I still need the patch I posted to build -rc5. Just FYI.

Rob

Signature · 12 lines

"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel