Corrections in Documentation/block/ioprio.txt

Hi Jens,

The newer glibc does not allow system calls to be made via _syscallN() wrapper. They have to be made through syscall(). The ionice code used the older interface. Correcting it to use syscall.

Signed-of-by Dhaval Giani <[email protected]>

Index: linux-2.6.23-rc3-mm1/Documentation/block/ioprio.txt
===================================================================

Quoted 14 lines · Dhaval Giani

Hi Jens,

The newer glibc does not allow system calls to be made via _syscallN() wrapper. They have to be made through syscall(). The ionice code used the older interface. Correcting it to use syscall.

Signed-of-by Dhaval Giani <[email protected]>

Index: linux-2.6.23-rc3-mm1/Documentation/block/ioprio.txt
===================================================================

Documentation/block/ioprio.txt extern int sys_ioprio_get(int, int); · line 91

Quoted 8 lines

Documentation/block/ioprio.txt +3 -2

@@ -86,8 +86,9 @@ extern int sys_ioprio_get(int, int);
 #error "Unsupported arch"
 #endif
 
-_syscall3(int, ioprio_set, int, which, int, who, int, ioprio);
-_syscall2(int, ioprio_get, int, which, int, who);
+#define ioprio_set(which, who, ioprio)  syscall(__NR_ioprio_set, which,\
+							who, ioprio)
+#define ioprio_get(which, who)	syscall(__NR_ioprio_get, which, who)

Agree, it fails as-of recent distros. But I prefer a function instead, can you resend with something ala:

static inline int ioprio_set(int which, int who, int ioprio)

{
        return syscall(__NR_ioprio_set, which, who, ioprio);
}

and ditto for ioprio_get()?

Signature · 1 line

Jens Axboe

Quoted 27 lines · Jens Axboe

Quoted 14 lines · Dhaval Giani

Hi Jens,

The newer glibc does not allow system calls to be made via _syscallN() wrapper. They have to be made through syscall(). The ionice code used the older interface. Correcting it to use syscall.

Signed-of-by Dhaval Giani <[email protected]>

Index: linux-2.6.23-rc3-mm1/Documentation/block/ioprio.txt
===================================================================

Documentation/block/ioprio.txt extern int sys_ioprio_get(int, int); · line 91

Quoted 8 lines

Documentation/block/ioprio.txt +3 -2

@@ -86,8 +86,9 @@ extern int sys_ioprio_get(int, int);
 #error "Unsupported arch"
 #endif
 
-_syscall3(int, ioprio_set, int, which, int, who, int, ioprio);
-_syscall2(int, ioprio_get, int, which, int, who);
+#define ioprio_set(which, who, ioprio)  syscall(__NR_ioprio_set, which,\
+							who, ioprio)
+#define ioprio_get(which, who)	syscall(__NR_ioprio_get, which, who)

Agree, it fails as-of recent distros. But I prefer a function instead, can you resend with something ala:

Quoted 9 lines

static inline int ioprio_set(int which, int who, int ioprio)

{
        return syscall(__NR_ioprio_set, which, who, ioprio);
}

and ditto for ioprio_get()?

Signature · 1 line

Jens Axboe

Done..

----------------------

The newer glibc does not allow system calls to be made via _syscallN() wrapper. They have to be made through syscall(). The ionice code used the older interface. Correcting it to use syscall.

Signed-off-by Dhaval Giani <[email protected]>

Index: linux-2.6.23-rc3-mm1/Documentation/block/ioprio.txt
===================================================================

Documentation/block/ioprio.txt +2 -2

@@ -86,8 +86,15 @@ extern int sys_ioprio_get(int, int);
 #error "Unsupported arch"
 #endif
 
-_syscall3(int, ioprio_set, int, which, int, who, int, ioprio);
-_syscall2(int, ioprio_get, int, which, int, who);
+static inline int ioprio_set(int which, int who, int ioprio)
+{