Skip to contentSkip to conversation

fix a trivial typo in scripts/checkstack.pl

PATCH In review [email protected] 5 participants 7 messages Aug 23, 2007 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 fix a trivial typo in scripts/checkstack.pl

---

scripts/checkstack.pl +1 -1
Index: linus/scripts/checkstack.pl
===================================================================
@@ -14,7 +14,7 @@
 #	M68k port by Geert Uytterhoeven and Andreas Schwab
 #
 #	Usage:
-#	objdump -d vmlinux | stackcheck.pl [arch]
+#	objdump -d vmlinux | scripts/checkstack.pl [arch]
 #
 #	TODO :	Port to all architectures (one regex per arch)
 

--

#2 lore raw

Trivial change in a comment.

---

scripts/checkstack.pl +1 -1
Index: linus/scripts/checkstack.pl
===================================================================
@@ -14,7 +14,7 @@
 #	M68k port by Geert Uytterhoeven and Andreas Schwab
 #
 #	Usage:
-#	objdump -d vmlinux | stackcheck.pl [arch]
+#	objdump -d vmlinux | scripts/checkstack.pl [arch]
 #
 #	TODO :	Port to all architectures (one regex per arch)
 

Jörn

Signature · 4 lines
Correctness comes second.
Features come third.
Performance comes last.
Maintainability is easily forgotten.
#3 lore raw
Quoted 10 lines · On Thu, 23 Aug 2007 15:13:02 +0200 Jörn Engel <[email protected]> wrote:

Trivial change in a comment.

---
Index: linus/scripts/checkstack.pl
===================================================================

scripts/checkstack.pl line 19

Quoted 7 lines
scripts/checkstack.pl +1 -1
@@ -14,7 +14,7 @@
 #	M68k port by Geert Uytterhoeven and Andreas Schwab
 #
 #	Usage:
-#	objdump -d vmlinux | stackcheck.pl [arch]
+#	objdump -d vmlinux | scripts/checkstack.pl [arch]
 #
 #	TODO :	Port to all architectures (one regex per arch)

Thanks, I forwarded this to Andy. I prefer not to apply checkpatch patches directly to -mm as it's still under a considerable amount of development and anything which I apply would just get tangled up with Andy's next update.

#4 lore raw
Quoted 17 lines · On Thu, 23 Aug 2007 14:11:16 -0700 Andrew Morton wrote:
Quoted 14 lines · On Thu, 23 Aug 2007 15:13:02 +0200 Jörn Engel <[email protected]> wrote:

Trivial change in a comment.

---
Index: linus/scripts/checkstack.pl
===================================================================

scripts/checkstack.pl +0 -1
@@ -14,7 +14,7 @@
 #	M68k port by Geert Uytterhoeven and Andreas Schwab
 #
 #	Usage:
-#	objdump -d vmlinux | stackcheck.pl [arch]
Quoted 8 lines

scripts/checkstack.pl line 19

Quoted 3 lines
scripts/checkstack.pl +1 -0
+#	objdump -d vmlinux | scripts/checkstack.pl [arch]
 #
 #	TODO :	Port to all architectures (one regex per arch)

Thanks, I forwarded this to Andy. I prefer not to apply checkpatch patches directly to -mm as it's still under a considerable amount of development and anything which I apply would just get tangled up with Andy's next update.

That's checkstack, not checkpatch...

The patch is correct, but most people use it (checkstack) via
make checkstack
AFAIK.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

#5 lore raw
In reply to [email protected]

scripts/checkstack.pl line 17

Quoted 13 lines · On Thu, Aug 23, 2007 at 02:55:40PM +0200, [email protected] wrote:

---
Index: linus/scripts/checkstack.pl
===================================================================

scripts/checkstack.pl +1 -1
@@ -14,7 +14,7 @@
 #	M68k port by Geert Uytterhoeven and Andreas Schwab
 #
 #	Usage:
-#	objdump -d vmlinux | stackcheck.pl [arch]
+#	objdump -d vmlinux | scripts/checkstack.pl [arch]
...

"make checkstack" ?

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#6 lore raw
Quoted 16 lines · Adrian Bunk

scripts/checkstack.pl line 17

Quoted 13 lines · On Thu, Aug 23, 2007 at 02:55:40PM +0200, [email protected] wrote:

---
Index: linus/scripts/checkstack.pl
===================================================================

scripts/checkstack.pl +1 -1
@@ -14,7 +14,7 @@
 #	M68k port by Geert Uytterhoeven and Andreas Schwab
 #
 #	Usage:
-#	objdump -d vmlinux | stackcheck.pl [arch]
+#	objdump -d vmlinux | scripts/checkstack.pl [arch]
...

"make checkstack" ?

If you really care about this, send a patch. An argument against it is that some people seem to use the script independently of the linux kernel. Not sure if all of them copy the makefile logic as well.

Does it matter?

Jörn

Signature · 2 lines
Anything that can go wrong, will.
-- Finagle's Law
#7 lore raw
Quoted 17 lines · On Thu, 23 Aug 2007 15:35:29 +0200 Jörn Engel wrote:
Quoted 16 lines · Adrian Bunk

scripts/checkstack.pl line 17

Quoted 13 lines · On Thu, Aug 23, 2007 at 02:55:40PM +0200, [email protected] wrote:

---
Index: linus/scripts/checkstack.pl
===================================================================

scripts/checkstack.pl +1 -1
@@ -14,7 +14,7 @@
 #	M68k port by Geert Uytterhoeven and Andreas Schwab
 #
 #	Usage:
-#	objdump -d vmlinux | stackcheck.pl [arch]
+#	objdump -d vmlinux | scripts/checkstack.pl [arch]
...

"make checkstack" ?

Yes, "make help" already lists this and the other check* scripts.

Quoted 5 lines

If you really care about this, send a patch. An argument against it is that some people seem to use the script independently of the linux kernel. Not sure if all of them copy the makefile logic as well.

Does it matter?

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***