Skip to contentSkip to conversation

USB fixes for 2.6.23-rc3

PATCH In review Greg KH 4 participants 8 messages Aug 22, 2007 – Aug 24, 2007

lore
Share & tools
lore

Greg KH

author
#0 lore raw

PATCH 1/1 USB fixes for 2.6.23-rc3

Here are some USB fixes against your 2.6.23-rc3 git tree.

They do the following:
- more quirk updates for broken devices.
- device id updates
- lots of little bugfixes
- compiler warning fixes

Most of these have been in the -mm tree for a while.

Please pull from:

	master.kernel.org:/pub/scm/linux/kernel/git/gregkh/usb-2.6.git/

The full patches will be sent to the linux-usb-devel mailing list, if anyone wants to see them.

thanks,

greg k-h

 drivers/media/video/em28xx/em28xx-video.c |    1 +
 drivers/media/video/pwc/pwc-if.c          |   52 +++++++++++-----
 drivers/media/video/pwc/pwc.h             |    1 +
 drivers/usb/Kconfig                       |    1 +
 drivers/usb/atm/cxacru.c                  |    3 +-
 drivers/usb/atm/ueagle-atm.c              |    5 +-
 drivers/usb/class/cdc-acm.c               |   12 +++-
 drivers/usb/core/driver.c                 |    9 +--
 drivers/usb/core/hub.c                    |    3 +-
 drivers/usb/core/message.c                |   28 ++++++++-
 drivers/usb/core/quirks.c                 |   12 ++++
 drivers/usb/gadget/dummy_hcd.c            |    2 -
 drivers/usb/gadget/file_storage.c         |   10 +--
 drivers/usb/gadget/fsl_usb2_udc.c         |   77 +++++++++++++-----------
 drivers/usb/gadget/pxa2xx_udc.c           |    4 +-
 drivers/usb/host/Kconfig                  |    2 +-
 drivers/usb/host/ehci-au1xxx.c            |    5 +-
 drivers/usb/host/ehci-ppc-soc.c           |   22 ++++++-
 drivers/usb/host/ohci-dbg.c               |    2 +-
 drivers/usb/host/r8a66597-hcd.c           |    2 -
 drivers/usb/host/u132-hcd.c               |    3 +
 drivers/usb/serial/airprime.c             |    1 -
 drivers/usb/serial/belkin_sa.c            |    4 +
 drivers/usb/serial/ftdi_sio.c             |    2 +
 drivers/usb/serial/ftdi_sio.h             |    3 +
 drivers/usb/serial/garmin_gps.c           |   93 +++++++++++++++--------------
 drivers/usb/serial/ipaq.c                 |    1 +
 drivers/usb/serial/option.c               |   10 ++-
 drivers/usb/serial/oti6858.c              |   10 +--
 drivers/usb/serial/safe_serial.c          |    6 +-
 drivers/usb/serial/visor.c                |    2 +
 drivers/usb/serial/visor.h                |    3 +
 drivers/usb/storage/unusual_devs.h        |    2 +-
 drivers/usb/storage/usb.c                 |   33 ++--------
 drivers/usb/storage/usb.h                 |    1 +
 35 files changed, 255 insertions(+), 172 deletions(-)

---------------

Alan Stern (7):
USB: cdc-acm: fix sysfs attribute registration bug
USB: remove DEBUG definition from dummy_hcd
USB: accept 1-byte Device Status replies, fixing some b0rken devices
usb-storage: fix bugs in the disconnect pathway
USB: allow retry on descriptor fetch errors
USB: update last_busy field correctly
USB: g_file_storage: fix bug in DMA buffer handling

Andy Green (1):
USB: belkin_sa: avoid divide by zero error

Christian Heim (1):
USB: Adding support for HTC Smartphones to ipaq

David Brownell (3):
USB: px2xx_udc bugfix, missing check for gpio_pullup
USB: quirks: multicard reader doesn't like autosuspend
USB: ohci, fix oddball gcc warning

Faidon Liambotis (1):
USB: fix support for Dell Wireless Broadband (aka WWAN)

Gabriel C (1):
USB: u132-hcd.c - Fix a warning when CONFIG_PM=n

Hermann Kneissel (1):
USB: serial: garmin_gps: fixes package loss if used from gpsbabel

Jesper Juhl (1):
USB: Fix a memory leak in em28xx_usb_probe()

Kay Sievers (1):
usb: add PRODUCT, TYPE to usb-interface events

Li Yang (1):
USB: fsl_usb2_udc: fix bug in processing setup requests

Luis Lloret (1):

      USB: Stall control endpoint when file storage class request wValue != 0

M4rkusXXL (1):
usb: typo in usb R8A66597 HCD config

Maximilian Attems (1):
USB: visor add ACER S10 palm device id

Mike Nuss (1):
USB: make EHCI initialize properly on PPC SOCs

Mike Pagano (1):
USB: resubmission unusual_devs modification for Nikon D80

Oliver Neukum (5):
USB: blacklist Samsung ML-2010 printer
USB: quirky mass storage device
USB: another quirky device
USB: unkill cxacru atm driver
USB: fix DoS in pwc USB video driver

Paul Mundt (2):
usb: Enable hcd support on SH unconditionally.
usb: r8a66597-hcd: fix up error path.

Paul Walmsley (1):
usb quirks: Add Canon EOS 5D (PC Connection mode) to the autosuspend blacklist

Robert P. J. Day (1):

      USB: Typo: "USB_SAFE_PADDED" -> "USB_SERIAL_SAFE_PADDED".

Stanislaw Gruszka (1):
UEAGLE: Remove sysfs files on error case

Søren Hauberg (1):
USB: Support for the Evolution Scorpion robots

Thomas Viehmann (1):
usb-serial: fix oti6858.c segfault in termios handling

#1 lore raw

Hi Greg,

sorry, this is a private egoistic request, so I took the liberty and removed Linus and Andrew from CC: If this wouldn't make things more difficult / worse for you and anyone else, could you perhaps post such patch chains as a reply to the first message (patch 0/x) and not each subsequent patch as a reply to the previous one? It would make it easier to view for _me_ (remember egoistic?) because my mail agent (pine) presents mail threads where every reply level produces a small right offset in the subject line, so, starting from about reply number 20 the subject is completely off-screen.

Again, this is a minor trouble, and, perhaps, I am the only one suffering from it, but if it doesn't matter either way for everyone else, I would really appreciate it that way.

Thanks
Guennadi
---
Guennadi Liakhovetski

author
#2 lore raw
Quoted 12 lines · Guennadi Liakhovetski

Hi Greg,

sorry, this is a private egoistic request, so I took the liberty and removed Linus and Andrew from CC: If this wouldn't make things more difficult / worse for you and anyone else, could you perhaps post such patch chains as a reply to the first message (patch 0/x) and not each subsequent patch as a reply to the previous one? It would make it easier to view for _me_ (remember egoistic?) because my mail agent (pine) presents mail threads where every reply level produces a small right offset in the subject line, so, starting from about reply number 20 the subject is completely off-screen.

Quoted 3 lines

Again, this is a minor trouble, and, perhaps, I am the only one suffering from it, but if it doesn't matter either way for everyone else, I would really appreciate it that way.

Heh, people ask me about this every few months or so, so you are not alone.

Unfortunately, I really like the cascade affect, it shows that the patches do have to be applied in consecutive order for them to work properly (which some people seem to forget and then get mad at me when they try to cherry-pick intermediate patches and apply them to older kernels for odd reasons...)

If I wanted to respond in an egotistical way, I could just tell you to use an email client that can handle the cascade affect properly, like mine does :)

thanks,

greg k-h

#3 lore raw
Quoted 9 lines · Greg KH

Unfortunately, I really like the cascade affect, it shows that the patches do have to be applied in consecutive order for them to work properly (which some people seem to forget and then get mad at me when they try to cherry-pick intermediate patches and apply them to older kernels for odd reasons...)

If I wanted to respond in an egotistical way, I could just tell you to use an email client that can handle the cascade affect properly, like mine does :)

Fair enough:-) No problem. Obviously, your argument has higher priority than mine, so, if this really becomes a problem for me, I'll find a solution for it, as well as everybody else suffering from this style.

Thanks
Guennadi
---
Guennadi Liakhovetski

#4 lore raw
In reply to Greg KH
Quoted 13 lines · On Thu, 23 Aug 2007 15:49:56 -0700 Greg KH wrote:
Quoted 12 lines · Guennadi Liakhovetski

Hi Greg,

sorry, this is a private egoistic request, so I took the liberty and removed Linus and Andrew from CC: If this wouldn't make things more difficult / worse for you and anyone else, could you perhaps post such patch chains as a reply to the first message (patch 0/x) and not each subsequent patch as a reply to the previous one? It would make it easier to view for _me_ (remember egoistic?) because my mail agent (pine) presents mail threads where every reply level produces a small right offset in the subject line, so, starting from about reply number 20 the subject is completely off-screen.

Quoted 6 lines
Quoted 3 lines

Again, this is a minor trouble, and, perhaps, I am the only one suffering from it, but if it doesn't matter either way for everyone else, I would really appreciate it that way.

Heh, people ask me about this every few months or so, so you are not alone.

I'd prefer that change also. In fact I just modified (trivial) send_lots_of_email.pl (gregkh_patchbomb mailer) to do this, except that I just have it create an mbox that I email via msmtp. (and it reads a 'sendpatchset' control file for input instead of needing to modify the script source file itself)

Quoted 5 lines

Unfortunately, I really like the cascade affect, it shows that the patches do have to be applied in consecutive order for them to work properly (which some people seem to forget and then get mad at me when they try to cherry-pick intermediate patches and apply them to older kernels for odd reasons...)

A patch series such as:

PATCH 0/n: intro/summary

|_ PATCH 1/n: desc1
|_ PATCH 2/n: desc2
|_ PATCH 3/n: desc3

should imply a patch order also, shouldn't it? At least it does to me and to users of Paul Jackson's 'sendpatchset' script, which acts in this way.

Quoted 3 lines

If I wanted to respond in an egotistical way, I could just tell you to use an email client that can handle the cascade affect properly, like mine does :)

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

author
#5 lore raw
Quoted 19 lines · Randy Dunlap
Quoted 17 lines · On Thu, 23 Aug 2007 15:49:56 -0700 Greg KH wrote:
Quoted 15 lines · Guennadi Liakhovetski

Hi Greg,

sorry, this is a private egoistic request, so I took the liberty and removed Linus and Andrew from CC: If this wouldn't make things more difficult / worse for you and anyone else, could you perhaps post such patch chains as a reply to the first message (patch 0/x) and not each subsequent patch as a reply to the previous one? It would make it easier to view for _me_ (remember egoistic?) because my mail agent (pine) presents mail threads where every reply level produces a small right offset in the subject line, so, starting from about reply number 20 the subject is completely off-screen.

Again, this is a minor trouble, and, perhaps, I am the only one suffering from it, but if it doesn't matter either way for everyone else, I would really appreciate it that way.

Quoted 8 lines
Quoted 2 lines

Heh, people ask me about this every few months or so, so you are not alone.

I'd prefer that change also. In fact I just modified (trivial) send_lots_of_email.pl (gregkh_patchbomb mailer) to do this, except that I just have it create an mbox that I email via msmtp. (and it reads a 'sendpatchset' control file for input instead of needing to modify the script source file itself)

I use git-send-email these days, and it already supports this with the --no-chain-reply-to option. I'll consider using it next time, if at least one more person complains about this :)

Quoted 8 lines

PATCH 0/n: intro/summary

|_ PATCH 1/n: desc1
|_ PATCH 2/n: desc2
|_ PATCH 3/n: desc3

should imply a patch order also, shouldn't it? At least it does to me and to users of Paul Jackson's 'sendpatchset' script, which acts in this way.

Yeah, you are right that things are now numbered, so it might be better (my old send_lots_of_email.pl script didn't number things very well, if at all from what I remember). But odds are, I'll
still get complaints. But hey, it looks like people will complain either way :)

thanks,

greg k-h

#6 lore raw
Quoted 29 lines · Greg KH
Quoted 19 lines · Randy Dunlap
Quoted 17 lines · On Thu, 23 Aug 2007 15:49:56 -0700 Greg KH wrote:
Quoted 15 lines · Guennadi Liakhovetski

Hi Greg,

sorry, this is a private egoistic request, so I took the liberty and removed Linus and Andrew from CC: If this wouldn't make things more difficult / worse for you and anyone else, could you perhaps post such patch chains as a reply to the first message (patch 0/x) and not each subsequent patch as a reply to the previous one? It would make it easier to view for _me_ (remember egoistic?) because my mail agent (pine) presents mail threads where every reply level produces a small right offset in the subject line, so, starting from about reply number 20 the subject is completely off-screen.

Again, this is a minor trouble, and, perhaps, I am the only one suffering from it, but if it doesn't matter either way for everyone else, I would really appreciate it that way.

Quoted 8 lines
Quoted 2 lines

Heh, people ask me about this every few months or so, so you are not alone.

I'd prefer that change also. In fact I just modified (trivial) send_lots_of_email.pl (gregkh_patchbomb mailer) to do this, except that I just have it create an mbox that I email via msmtp. (and it reads a 'sendpatchset' control file for input instead of needing to modify the script source file itself)

Quoted 4 lines

I use git-send-email these days, and it already supports this with the --no-chain-reply-to option. I'll consider using it next time, if at least one more person complains about this :)
...

*complain* :)

Quoted 3 lines

thanks,

greg k-h

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
author
#7 lore raw
Quoted 30 lines · Adrian Bunk
Quoted 29 lines · Greg KH
Quoted 27 lines · Randy Dunlap
Quoted 13 lines · On Thu, 23 Aug 2007 15:49:56 -0700 Greg KH wrote:
Quoted 12 lines · Guennadi Liakhovetski

Hi Greg,

sorry, this is a private egoistic request, so I took the liberty and removed Linus and Andrew from CC: If this wouldn't make things more difficult / worse for you and anyone else, could you perhaps post such patch chains as a reply to the first message (patch 0/x) and not each subsequent patch as a reply to the previous one? It would make it easier to view for _me_ (remember egoistic?) because my mail agent (pine) presents mail threads where every reply level produces a small right offset in the subject line, so, starting from about reply number 20 the subject is completely off-screen.

Quoted 6 lines
Quoted 3 lines

Again, this is a minor trouble, and, perhaps, I am the only one suffering from it, but if it doesn't matter either way for everyone else, I would really appreciate it that way.

Heh, people ask me about this every few months or so, so you are not alone.

I'd prefer that change also. In fact I just modified (trivial) send_lots_of_email.pl (gregkh_patchbomb mailer) to do this, except that I just have it create an mbox that I email via msmtp. (and it reads a 'sendpatchset' control file for input instead of needing to modify the script source file itself)

Quoted 6 lines
Quoted 4 lines

I use git-send-email these days, and it already supports this with the --no-chain-reply-to option. I'll consider using it next time, if at least one more person complains about this :)
...

*complain* :)

Heh, ok, fair enough, I'll do --no-chain-reply-to next time and see how it turns out.

thanks,

greg k-h