Skip to contentSkip to conversation

DM_MULTIPATH_RDAC: "scsi_normalize_sense" undefined

DISCUSSION Martin Michlmayr 3 participants 6 messages Aug 24, 2007 – Aug 25, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

I just got:

Building modules, stage 2.
MODPOST 414 modules
ERROR: "scsi_normalize_sense" [drivers/md/dm-rdac.ko] undefined! make[1]: *** [__modpost] Error 1

Presumably DM_MULTIPATH_RDAC needs to depend on SCSI (not enabled here) since it uses scsi_normalize_sense.

Signature · 2 lines
Martin Michlmayr
http://www.cyrius.com/
#1 lore raw

It does, but "rdac" _is_ for a SCSI device.

What device are you using it with ?

Quoted 9 lines · Martin Michlmayr

I just got:

Building modules, stage 2.
MODPOST 414 modules
ERROR: "scsi_normalize_sense" [drivers/md/dm-rdac.ko] undefined! make[1]: *** [__modpost] Error 1

Presumably DM_MULTIPATH_RDAC needs to depend on SCSI (not enabled here) since it uses scsi_normalize_sense.

Signature · 4 lines
----------------------------------------------------------------------
    Chandra Seetharaman               | Be careful what you choose....
              - [email protected]   |      .......you may get it.
----------------------------------------------------------------------
#2 lore raw
Quoted 1 line · On Fri, 24 Aug 2007 14:33:02 -0700 Chandra Seetharaman wrote:

It does, but "rdac" _is_ for a SCSI device.

It does __what__ ? depend on SCSI?
I don't see that in drivers/md/Kconfig.
Sounds like Martin is correct, SCSI needs to be added, like below.

Quoted 12 lines

What device are you using it with ?

Quoted 9 lines · Martin Michlmayr

I just got:

Building modules, stage 2.
MODPOST 414 modules
ERROR: "scsi_normalize_sense" [drivers/md/dm-rdac.ko] undefined! make[1]: *** [__modpost] Error 1

Presumably DM_MULTIPATH_RDAC needs to depend on SCSI (not enabled here) since it uses scsi_normalize_sense.

---

From: Randy Dunlap <[email protected]>

DM_MULTIPATH_RDAC uses SCSI API(s) and is for a SCSI device, so add SCSI to its depends on to prevent build errors.

Not tested.

---
 drivers/md/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/md/Kconfig +1 -1
@@ -263,7 +263,7 @@ config DM_MULTIPATH_EMC
 
 config DM_MULTIPATH_RDAC
 	tristate "LSI/Engenio RDAC multipath support (EXPERIMENTAL)"
-	depends on DM_MULTIPATH && BLK_DEV_DM && EXPERIMENTAL
+	depends on DM_MULTIPATH && BLK_DEV_DM && SCSI && EXPERIMENTAL
 	---help---
 	  Multipath support for LSI/Engenio RDAC.
 
#3 lore raw
Quoted 5 lines · Randy Dunlap
Quoted 1 line · On Fri, 24 Aug 2007 14:33:02 -0700 Chandra Seetharaman wrote:

It does, but "rdac" _is_ for a SCSI device.

It does __what__ ? depend on SCSI?

Yes, as you understood it correctly :)

Quoted 2 lines

I don't see that in drivers/md/Kconfig.
Sounds like Martin is correct, SCSI needs to be added, like below.

I do agree that the following patch would be needed.

Since the rdac hardware handler is for a scsi device, including it without SCSI would not achieve anything (as his device won't be visible in the first place). Hence my question.

For completeness, I agree that we need the fix pointed below.

Quoted 40 lines
Quoted 14 lines

What device are you using it with ?

Quoted 9 lines · Martin Michlmayr

I just got:

Building modules, stage 2.
MODPOST 414 modules
ERROR: "scsi_normalize_sense" [drivers/md/dm-rdac.ko] undefined! make[1]: *** [__modpost] Error 1

Presumably DM_MULTIPATH_RDAC needs to depend on SCSI (not enabled here) since it uses scsi_normalize_sense.

---

From: Randy Dunlap <[email protected]>

DM_MULTIPATH_RDAC uses SCSI API(s) and is for a SCSI device, so add SCSI to its depends on to prevent build errors.

Not tested.

---
 drivers/md/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/md/Kconfig +1 -1
@@ -263,7 +263,7 @@ config DM_MULTIPATH_EMC
 
 config DM_MULTIPATH_RDAC
 	tristate "LSI/Engenio RDAC multipath support (EXPERIMENTAL)"
-	depends on DM_MULTIPATH && BLK_DEV_DM && EXPERIMENTAL
+	depends on DM_MULTIPATH && BLK_DEV_DM && SCSI && EXPERIMENTAL
 	---help---
 	  Multipath support for LSI/Engenio RDAC.
 
Signature · 4 lines
----------------------------------------------------------------------
    Chandra Seetharaman               | Be careful what you choose....
              - [email protected]   |      .......you may get it.
----------------------------------------------------------------------
#5 lore raw
In reply to Chandra Seetharaman
Quoted 3 lines · Chandra Seetharaman

It does, but "rdac" _is_ for a SCSI device.

What device are you using it with ?

I'm not using it at all. I merely compiled a kernel where DM_MULTIPATH_RDAC was activated by chance without SCSI. Randy's patch looks good.

Signature · 2 lines
Martin Michlmayr
http://www.cyrius.com/