Skip to contentSkip to conversation

scheduler updates

GIT PULL Ingo Molnar 2 participants 4 messages Aug 28, 2007

lore
Share & tools
lore
#0 lore raw

Linus, please pull the latest scheduler git tree from:

git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched.git

no big changes - 5 small fixes and 1 small cleanup:

- the only bug with a human-noticeable effect is a bonus-limit oneliner bug found and fixed by Mike: Mike has done interactivity testing of -rc4 and found a relatively minor but noticeable Amarok song-switch-latency increase under high load. (This bug was a side-effect of the recent adaptive-latency patch - mea culpa.)

- there's a fix for a new_task_fair() bug found by Ting Yang: Ting has done a comprehensive review of the latest CFS code and found this problem which caused a random jitter of 1 jiffy of the key value for newly started up tasks. Saw no immediate effects from this fix (this amount of jitter is noise in most cases and the effect averages out over longer time), but it's worth having the fix in .23 nevertheless.

- then there's a converge-to-ideal-latency change that fixes a pre-existing property of CFS. This is not a bug per se but is still worth fixing for .23 - the before/after chew-max output in the changelog shows the clear benefits in consistency of scheduling. Affects the preemption slowpath only. Should be human-unnoticeable. [ We would not have this fix if it wasnt for the de-HZ-ification change of the tunables, so i'm glad we got rid of the HZ uglies in one go - they just hid this real problem. ]

- Peter noticed a bug in the SCHED_FEAT_SKIP_INITIAL code - but this is off by default so it's a NOP on the default kernel.

- a small schedstat fix [NOP for defconfig]. This bug was there since the first CFS commit.

- a small task_new_fair() cleanup [NOP].

Ingo

------------------>
Ingo Molnar (4):
sched: make the scheduler converge to the ideal latency
sched: fix wait_start_fair condition in update_stats_wait_end()
sched: small schedstat fix
sched: clean up task_new_fair()

Mike Galbraith (1):
sched: fix sleeper bonus limit

Ting Yang (1):
sched: call update_curr() in task_tick_fair()

 include/linux/sched.h |    1 +
 kernel/sched.c        |    1 +
 kernel/sched_fair.c   |   46 +++++++++++++++++++++++++++++++++++-----------
 3 files changed, 37 insertions(+), 11 deletions(-)
#1 lore raw
Quoted 5 lines · Ingo Molnar

Linus, please pull the latest scheduler git tree from:

git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched.git

no big changes - 5 small fixes and 1 small cleanup:

FWIW, I spent a few hours testing these patches with various loads, and all was peachy here. No multimedia or interactivity aberrations noted.

-Mike

#2 lore raw
Quoted 10 lines · Mike Galbraith
Quoted 5 lines · Ingo Molnar

Linus, please pull the latest scheduler git tree from:

git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched.git

no big changes - 5 small fixes and 1 small cleanup:

FWIW, I spent a few hours testing these patches with various loads, and all was peachy here. No multimedia or interactivity aberrations noted.

great! Btw., there's another refinement Peter and me are working on (see the patch below): to place new tasks into the existing 'scheduling flow' in a more seemless way. In practice this should mean less firefox spikes during a kbuild workload. If you have some time to try it, could you add the patch below to your tree too, and see what happens during fork-happy workloads? It does not seem to be overly urgent to apply at the moment, but it is a nice touch i think.

Ingo

------------------------>
Subject: sched: place new tasks in the middle of the task pool
From: Peter Zijlstra <[email protected]>

Place new tasks in the middle of the wait_runtime average. This smoothes out latency spikes caused by freshly started tasks, without being unfair to those tasks. Basically new tasks start right into the 'flow' of wait_runtime that exists in the system at that moment.

[ [email protected]: changed it to use cfs_rq->wait_runtime ]

---
 kernel/sched.c      |    1 
 kernel/sched_fair.c |   59 +++++++++++++++++++++++++++++-----------------------
 2 files changed, 33 insertions(+), 27 deletions(-)
kernel/sched.c +0 -1
Index: linux/kernel/sched.c
===================================================================
@@ -858,7 +858,6 @@ static void dec_nr_running(struct task_s
 
 static void set_load_weight(struct task_struct *p)
 {
-	task_rq(p)->cfs.wait_runtime -= p->se.wait_runtime;
 	p->se.wait_runtime = 0;
 
 	if (task_has_rt_policy(p)) {
kernel/sched_fair.c +33 -26

136 lines not on this page · raw message

#3 lore raw
Quoted 13 lines · Ingo Molnar
Quoted 10 lines · Mike Galbraith
Quoted 5 lines · Ingo Molnar

Linus, please pull the latest scheduler git tree from:

git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched.git

no big changes - 5 small fixes and 1 small cleanup:

FWIW, I spent a few hours testing these patches with various loads, and all was peachy here. No multimedia or interactivity aberrations noted.

Quoted 7 lines

great! Btw., there's another refinement Peter and me are working on (see the patch below): to place new tasks into the existing 'scheduling flow' in a more seemless way. In practice this should mean less firefox spikes during a kbuild workload. If you have some time to try it, could you add the patch below to your tree too, and see what happens during fork-happy workloads? It does not seem to be overly urgent to apply at the moment, but it is a nice touch i think.

Sure, I'll give it a try. (i was just adding likely post 24 merge candidates to give them some runtime anyway, one more to the queue)

-Mike